From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19055 invoked by alias); 27 Jan 2007 17:36:46 -0000 Received: (qmail 19046 invoked by uid 22791); 27 Jan 2007 17:36:45 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO,TW_PX X-Spam-Check-By: sourceware.org Received: from tomts5.bellnexxia.net (HELO tomts5-srv.bellnexxia.net) (209.226.175.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 27 Jan 2007 17:36:40 +0000 Received: from krystal.dyndns.org ([67.68.205.109]) by tomts5-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070127173638.WKMY5067.tomts5-srv.bellnexxia.net@krystal.dyndns.org> for ; Sat, 27 Jan 2007 12:36:38 -0500 Received: from localhost (localhost [127.0.0.1]) (uid 1000) by krystal.dyndns.org with local; Sat, 27 Jan 2007 12:31:24 -0500 id 001DAFAF.45BB8C6C.00002771 Date: Sat, 27 Jan 2007 17:36:00 -0000 From: Mathieu Desnoyers To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Greg Kroah-Hartman , Christoph Hellwig , ltt-dev@shafik.org, systemtap@sources.redhat.com, Douglas Niehaus , "Martin J. Bligh" , Thomas Gleixner , Paul Mackerras Subject: Re: [PATCH 00/09] atomic.h : standardizing atomic primitives Message-ID: <20070127173124.GA25282@Krystal> References: <11697417541743-git-send-email-mathieu.desnoyers@polymtl.ca> <20070127021834.e26e955d.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20070127021834.e26e955d.akpm@osdl.org> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.4.32-grsec (i686) X-Uptime: 12:30:00 up 157 days, 14:37, 2 users, load average: 0.24, 0.43, 0.42 User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00239.txt.bz2 * Andrew Morton (akpm@osdl.org) wrote: > On Thu, 25 Jan 2007 11:15:45 -0500 > Mathieu Desnoyers wrote: > > > It mainly adds support for missing 64 bits cmpxchg and 64 bits atomic add > > unless. Therefore, principally 64 bits architectures are targeted by these > > patches. It also adds the complete list of atomic operations on the atomic_long > > type. > > OK, I fixed eight separate compile errors in this patch series and > now powerpc is being very ugly with a twisty maze of include dependencies. > > I'm giving up. Someone should publish a suite of cross-compilers for us > so stuff like this doesn't need to happen. Hi Andrew, This seems to be caused by the fact that I use inline functions for atomic_long_cmpxchg and atomic_long_xchg. I could simply use macros and this problem would fade away. I agree about the cross-compiler suite, it would be very useful here. Mathieu -- OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68