From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
systemtap@sources.redhat.com, ltt-dev@shafik.org
Subject: Re: [PATCH 02/05] Linux Kernel Markers, architecture independant code.
Date: Thu, 15 Feb 2007 19:12:00 -0000 [thread overview]
Message-ID: <20070215191222.GB31359@Krystal> (raw)
In-Reply-To: <20070214232137.7aa86259.akpm@linux-foundation.org>
* Andrew Morton (akpm@linux-foundation.org) wrote:
> On Sun, 11 Feb 2007 15:03:24 -0500 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
>
> > Linux Kernel Markers, architecture independant code.
> >
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> >
> > ...
> >
> > +
> > +#ifndef MARK
> > +#define MARK GEN_MARK
> > +#define MARK_ENABLE_TYPE GEN_MARK_ENABLE_TYPE
> > +#define MARK_ENABLE_IMMEDIATE_OFFSET GEN_MARK_ENABLE_IMMEDIATE_OFFSET
> > +#endif
>
> Also perhaps this nastiness can go away once each architecture has
> asm/marker.h?
>
Yes, absolutely.
> > +#ifdef MARK_POLYMORPHIC
>
> What's this? Is it commented somewhere? (It should be...)
>
No, but should be : it is defined by the architecture's marker.h when
the marker flavor has to do code motification when the marker state is
modified.
> > +static int marker_set_ins_enable(void *address, char enable)
> > +{
> > +#ifdef CONFIG_X86_32
> > + return arch_marker_set_ins_enable(address, enable);
> > +#else
> > + char newi[MARK_ENABLE_IMMEDIATE_OFFSET+1];
> > + int size = MARK_ENABLE_IMMEDIATE_OFFSET+sizeof(MARK_ENABLE_TYPE);
> > +
> > + memcpy(newi, address, size);
> > + MARK_ENABLE(&newi[0]) = enable;
> > + memcpy(address, newi, size);
> > + flush_icache_range((unsigned long)address, size);
> > + return 0;
> > +#endif //CONFIG_X86_32
> > +}
>
> eww. Can we put a suitable arch_marker_set_ins_enable() into each arch's
> marker.h?
>
Or maybe put that in asm-generic so we do not duplicate code.
> > +#else
> > +static int marker_set_ins_enable(void *address, char enable)
> > +{
> > + return -EPERM;
> > +}
> > +#endif //MARK_POLYMORPHIC
> > +
> >
> > ...
> >
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, École Polytechnique de Montréal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-02-15 19:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 20:13 [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20 Mathieu Desnoyers
2007-02-11 20:03 ` [PATCH 03/05] Linux Kernel Markers : powerpc optimization Mathieu Desnoyers
2007-02-11 20:03 ` [PATCH 01/05] Linux Kernel Markers : Kconfig menus Mathieu Desnoyers
2007-02-11 20:08 ` [PATCH 02/05] Linux Kernel Markers, architecture independant code Mathieu Desnoyers
2007-02-15 7:22 ` Andrew Morton
2007-02-15 19:12 ` Mathieu Desnoyers [this message]
2007-02-11 20:13 ` [PATCH 04/05] Linux Kernel Markers : i386 optimization Mathieu Desnoyers
2007-02-11 20:44 ` [PATCH 05/05] Linux Kernel Markers, non optimized architectures Mathieu Desnoyers
2007-02-15 7:17 ` Andrew Morton
2007-02-15 19:09 ` Mathieu Desnoyers
2007-02-16 20:10 ` Karim Yaghmour
2007-02-16 23:38 ` Mathieu Desnoyers
2007-02-21 19:53 ` Karim Yaghmour
2007-02-21 20:51 ` Mathieu Desnoyers
2007-02-21 21:50 ` Karim Yaghmour
2007-02-22 0:18 ` [PATCH] Linux Kernel Markers - cleanup Mathieu Desnoyers
2007-02-15 7:12 ` [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20 Andrew Morton
2007-02-15 15:29 ` Frank Ch. Eigler
2007-02-15 22:19 ` Andrew Morton
2007-02-15 22:36 ` Mathieu Desnoyers
2007-02-15 23:15 ` Vara Prasad
2007-02-16 1:34 ` [PATCH] Linux Kernel Markers Documentation Mathieu Desnoyers
2007-02-16 1:51 ` Randy Dunlap
2007-02-16 4:01 ` Mathieu Desnoyers
2007-02-16 4:05 ` [PATCH] Linux Kernel Markers Documentation - fix Mathieu Desnoyers
2007-02-16 1:37 ` [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20 Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2007-01-12 0:02 [PATCH 00/05] Linux Kernel Markers Mathieu Desnoyers
2007-01-12 0:07 ` [PATCH 02/05] Linux Kernel Markers, architecture independant code Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070215191222.GB31359@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=mingo@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).