From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
systemtap@sources.redhat.com, ltt-dev@shafik.org
Subject: Re: [PATCH] Linux Kernel Markers Documentation
Date: Fri, 16 Feb 2007 04:01:00 -0000 [thread overview]
Message-ID: <20070216035603.GB16075@Krystal> (raw)
In-Reply-To: <20070215174500.2b1b3bb9.randy.dunlap@oracle.com>
Hi Randy,
* Randy Dunlap (randy.dunlap@oracle.com) wrote:
> so is the MARK() supposed to be:
> MARK(subsystem, event, ...
>
> Please make the 2 doc. lines above match the parameters...
> or the parameters match the text.
>
Fixing the paragraph below.
> > +- "%d %s %p[struct task_struct]" is the formatted string for (printk-style).
> > +- someint is an integer.
> > +- somestring is a char pointer.
> > +- current is a pointer to a struct task_struct.
> > +
> > +The expression %p[struct task_struct] is a suggested marker definition
> > +standard that could eventually be used for pointer type checking in
> > +sparse. The brackets contain the type to which the pointer refer.
> refers.
>
> > +
> > +#define SUBSYSTEM_EVENT_FORMAT "%d %s %p[struct task_struct]"
>
> Is SUBSYSTEM_EVENT_FORMAT used implicitly below? or elsewhere?
>
Yes, error follows.
> > +void probe_subsystem_event(const char *format, ...)
> > +{
> > + va_list ap;
> > + /* Declare args */
> > + unsigned int value;
> > + const char *mystr;
> > + struct task_struct *task;
> > +
> > + /* Assign args */
> > + va_start(ap, format);
> > + value = va_arg(ap, typeof(value));
> > + mystr = va_arg(ap, typeof(mystr));
> > + task = va_arg(ap, typeof(task));
> > +
> > + /* Call tracer */
> > + trace_subsystem_event(value, mystr, task);
> > +
> > + /* Or call printk */
> > + vprintk(format, ap);
> > +
> > + /* or count, check rights... */
> > +
> > + va_end(ap);
> > +}
> > +
> > +static int __init probe_init(void)
> > +{
> > + int result;
> > + result = marker_set_probe("subsystem_event",
> > + FS_CLOSE_FORMAT,
> > + probe_fs_close);
>
> Do FS_CLOSE_FORMAT and probe_fs_close() need to be defined here?
> I.e., is this a complete example?
>
should be SUBSYSTEM_EVENT_FORMAT. Will fix, thanks.
Regards,
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-02-16 4:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 20:13 [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20 Mathieu Desnoyers
2007-02-11 20:03 ` [PATCH 01/05] Linux Kernel Markers : Kconfig menus Mathieu Desnoyers
2007-02-11 20:03 ` [PATCH 03/05] Linux Kernel Markers : powerpc optimization Mathieu Desnoyers
2007-02-11 20:08 ` [PATCH 02/05] Linux Kernel Markers, architecture independant code Mathieu Desnoyers
2007-02-15 7:22 ` Andrew Morton
2007-02-15 19:12 ` Mathieu Desnoyers
2007-02-11 20:13 ` [PATCH 04/05] Linux Kernel Markers : i386 optimization Mathieu Desnoyers
2007-02-11 20:44 ` [PATCH 05/05] Linux Kernel Markers, non optimized architectures Mathieu Desnoyers
2007-02-15 7:17 ` Andrew Morton
2007-02-15 19:09 ` Mathieu Desnoyers
2007-02-16 20:10 ` Karim Yaghmour
2007-02-16 23:38 ` Mathieu Desnoyers
2007-02-21 19:53 ` Karim Yaghmour
2007-02-21 20:51 ` Mathieu Desnoyers
2007-02-21 21:50 ` Karim Yaghmour
2007-02-22 0:18 ` [PATCH] Linux Kernel Markers - cleanup Mathieu Desnoyers
2007-02-15 7:12 ` [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20 Andrew Morton
2007-02-15 15:29 ` Frank Ch. Eigler
2007-02-15 22:19 ` Andrew Morton
2007-02-15 22:36 ` Mathieu Desnoyers
2007-02-15 23:15 ` Vara Prasad
2007-02-16 1:34 ` [PATCH] Linux Kernel Markers Documentation Mathieu Desnoyers
2007-02-16 1:51 ` Randy Dunlap
2007-02-16 4:01 ` Mathieu Desnoyers [this message]
2007-02-16 4:05 ` [PATCH] Linux Kernel Markers Documentation - fix Mathieu Desnoyers
2007-02-16 1:37 ` [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216035603.GB16075@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=mingo@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).