_stp_pid no longer there?

_stp_pid no longer there?

[Sébastien Dugué]

  Hi all,

  I just discovered that the _stp_pid module parameter has just vanished
from runtime/transport/transport.c.

  What is supposed to replace it or how one is supposed to retreive staprun's
pid from within a script as it is used by tapsets?

  Thanks,

  Sébastien.

  

Re: _stp_pid no longer there?

[Andreas Kostyrka]

* Sébastien Dugué <sebastien.dugue@bull.net> [070328 12:27]:
> 
>   Hi all,
> 
>   I just discovered that the _stp_pid module parameter has just vanished
> from runtime/transport/transport.c.
> 
>   What is supposed to replace it or how one is supposed to retreive staprun's
> pid from within a script as it is used by tapsets?
pid() ?

Andreas

Re: _stp_pid no longer there?

[Sébastien Dugué]

On Wed, 28 Mar 2007 12:27:46 +0200 Andreas Kostyrka <andreas@kostyrka.org> wrote:

> * Sébastien Dugué <sebastien.dugue@bull.net> [070328 12:27]:
> > 
> >   Hi all,
> > 
> >   I just discovered that the _stp_pid module parameter has just vanished
> > from runtime/transport/transport.c.
> > 
> >   What is supposed to replace it or how one is supposed to retreive staprun's
> > pid from within a script as it is used by tapsets?
> pid() ?
> 

  I don't think so, unless I'm missing something, as far as I can tell pid()
returns current->tgid.

  Sébastien.

Re: _stp_pid no longer there?

[Frank Ch. Eigler]

SÚbastien DuguÚ <sebastien.dugue@bull.net> writes:

> I just discovered that the _stp_pid module parameter has just
> vanished from runtime/transport/transport.c.

Yes, it seems to have gone away with the recent rewrite of the area.
This might have been because

> What is supposed to replace it or how one is supposed to retreive
> staprun's pid from within a script as it is used by tapsets?

Using variables defined by runtime C code directly is not appropriate.
Such code is considered to be a private interface between the
translator, the provided tapsets, and the runtime, and thus may change
frequently.

However, I agree that it is sometimes desirable to filter out events
caused caused by staprun's activities, so a properly documented and
tapset-exported version of that pid number should come back.

- FChE

Re: _stp_pid no longer there?

[Sébastien Dugué]

On 28 Mar 2007 10:20:35 -0400 fche@redhat.com (Frank Ch. Eigler) wrote:

> SÚbastien DuguÚ <sebastien.dugue@bull.net> writes:
> 
> > I just discovered that the _stp_pid module parameter has just
> > vanished from runtime/transport/transport.c.
> 
> Yes, it seems to have gone away with the recent rewrite of the area.
> This might have been because
> 
> > What is supposed to replace it or how one is supposed to retreive
> > staprun's pid from within a script as it is used by tapsets?
> 
> Using variables defined by runtime C code directly is not appropriate.
> Such code is considered to be a private interface between the
> translator, the provided tapsets, and the runtime, and thus may change
> frequently.

  I do not use this variable directly, it's simply that some of the tapsets
use it, namely tapset/context.stp, tapset/LKET/utils.stp and
tapset/LKET/tskdispatch.stp.

> 
> However, I agree that it is sometimes desirable to filter out events
> caused caused by staprun's activities, so a properly documented and
> tapset-exported version of that pid number should come back.

  Yep. I tripped it just running the testsuite.

  Thanks,

  Sébastien.

Re: _stp_pid no longer there?

[Frank Ch. Eigler]

Hi -

On Wed, Mar 28, 2007 at 05:31:30PM +0200, Sébastien Dugué wrote:
> [...]
> I do not use this variable directly, it's simply that some of the tapsets
> use it, namely tapset/context.stp, tapset/LKET/utils.stp and
> tapset/LKET/tskdispatch.stp.

Very good point.
 
>   Yep. I tripped it just running the testsuite.

That's reassuring, but really, we systemtap developers have been too
sloppy with adding code (functions, probes) to the tapset without (a)
documentation, and (b) test suite entries, all contrary to the
guidelines of src/HACKING.  Let's try harder to follow them.

- FChE

Re: _stp_pid no longer there?

[Martin Hunt]

On Wed, 2007-03-28 at 12:08 +0200, Sébastien Dugué wrote:
>   Hi all,
> 
>   I just discovered that the _stp_pid module parameter has just vanished
> from runtime/transport/transport.c.

Sorry, my fault.  I removed the old code and did not check in a
replacement yet.  I'll get it in later today once I've tested on a few
older kernels.  Probably should get something in the testsuite too.

>   What is supposed to replace it or how one is supposed to retreive staprun's
> pid from within a script as it is used by tapsets?

The stp_pid() function in context.stp  should work like it used to.

Martin

Re: _stp_pid no longer there?

[Sébastien Dugué]

On Wed, 28 Mar 2007 10:48:36 -0400 Martin Hunt <hunt@redhat.com> wrote:

> On Wed, 2007-03-28 at 12:08 +0200, Sébastien Dugué wrote:
> >   Hi all,
> > 
> >   I just discovered that the _stp_pid module parameter has just vanished
> > from runtime/transport/transport.c.
> 
> Sorry, my fault.  I removed the old code and did not check in a
> replacement yet.  I'll get it in later today once I've tested on a few
> older kernels.  Probably should get something in the testsuite too.

  No problem.

> 
> >   What is supposed to replace it or how one is supposed to retreive staprun's
> > pid from within a script as it is used by tapsets?
> 
> The stp_pid() function in context.stp  should work like it used to.
> 

  How could it? it just references __stp_pid.

  just try a:

    stap -vv -p4 -e 'probe begin {printf("staprun pid %d\n", stp_pid())}'


  Thanks,

  Sébastien.

Re: _stp_pid no longer there?

[Martin Hunt]

On Wed, 2007-03-28 at 17:37 +0200, Sébastien Dugué wrote:
> On Wed, 28 Mar 2007 10:48:36 -0400 Martin Hunt <hunt@redhat.com> wrote:

> > The stp_pid() function in context.stp  should work like it used to.
> > 
> 
>   How could it? it just references __stp_pid.
> 
>   just try a:
> 
>     stap -vv -p4 -e 'probe begin {printf("staprun pid %d\n", stp_pid())}'

I meant it would work like normal once I fixed it.

I've checked in the fix for newer kernels with debugfs. For older
kernels I will get the patch in later once I have had a chance to test
it.

Martin

Re: _stp_pid no longer there?

[Sébastien Dugué]

On Wed, 28 Mar 2007 12:13:26 -0400 Martin Hunt <hunt@redhat.com> wrote:

> On Wed, 2007-03-28 at 17:37 +0200, Sébastien Dugué wrote:
> > On Wed, 28 Mar 2007 10:48:36 -0400 Martin Hunt <hunt@redhat.com> wrote:
> 
> > > The stp_pid() function in context.stp  should work like it used to.
> > > 
> > 
> >   How could it? it just references __stp_pid.
> > 
> >   just try a:
> > 
> >     stap -vv -p4 -e 'probe begin {printf("staprun pid %d\n", stp_pid())}'
> 
> I meant it would work like normal once I fixed it.

  Ok, sorry, just misunderstood you.

> 
> I've checked in the fix for newer kernels with debugfs. For older
> kernels I will get the patch in later once I have had a chance to test
> it.

  Thanks.

  Sébastien.