From: "Frank Ch. Eigler" <fche@redhat.com>
To: "Sébastien Dugué" <sebastien.dugue@bull.net>
Cc: systemtap <systemtap@sources.redhat.com>,
Pierre PEIFFER <pierre.peiffer@bull.net>
Subject: Re: _stp_pid no longer there?
Date: Wed, 28 Mar 2007 17:23:00 -0000 [thread overview]
Message-ID: <20070328172320.GA26915@redhat.com> (raw)
In-Reply-To: <20070328173130.62b18f0b@frecb000686.frec.bull.fr>
Hi -
On Wed, Mar 28, 2007 at 05:31:30PM +0200, Sébastien Dugué wrote:
> [...]
> I do not use this variable directly, it's simply that some of the tapsets
> use it, namely tapset/context.stp, tapset/LKET/utils.stp and
> tapset/LKET/tskdispatch.stp.
Very good point.
> Yep. I tripped it just running the testsuite.
That's reassuring, but really, we systemtap developers have been too
sloppy with adding code (functions, probes) to the tapset without (a)
documentation, and (b) test suite entries, all contrary to the
guidelines of src/HACKING. Let's try harder to follow them.
- FChE
next prev parent reply other threads:[~2007-03-28 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 10:11 Sébastien Dugué
2007-03-28 10:26 ` Andreas Kostyrka
2007-03-28 10:51 ` Sébastien Dugué
2007-03-28 14:20 ` Frank Ch. Eigler
2007-03-28 15:34 ` Sébastien Dugué
2007-03-28 17:23 ` Frank Ch. Eigler [this message]
2007-03-28 14:48 ` Martin Hunt
2007-03-28 15:40 ` Sébastien Dugué
2007-03-28 16:13 ` Martin Hunt
2007-03-29 6:50 ` Sébastien Dugué
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328172320.GA26915@redhat.com \
--to=fche@redhat.com \
--cc=pierre.peiffer@bull.net \
--cc=sebastien.dugue@bull.net \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).