From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-5932-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 15204 invoked by alias); 28 Mar 2007 17:23:35 -0000
Received: (qmail 15185 invoked by uid 22791); 28 Mar 2007 17:23:35 -0000
X-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Mar 2007 18:23:28 +0100
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l2SHNOKB012828; 	Wed, 28 Mar 2007 13:23:25 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l2SHNNu2025099; 	Wed, 28 Mar 2007 13:23:23 -0400
Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) 	by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l2SHNNkn028620; 	Wed, 28 Mar 2007 13:23:23 -0400
Received: from ton.toronto.redhat.com (ton.toronto.redhat.com [172.16.14.15]) 	by touchme.toronto.redhat.com (Postfix) with ESMTP 	id 4DEDF800052; Wed, 28 Mar 2007 12:23:23 -0500 (EST)
Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) 	by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id l2SHNNVf000475; 	Wed, 28 Mar 2007 13:23:23 -0400
Received: (from fche@localhost) 	by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id l2SHNKJr000469; 	Wed, 28 Mar 2007 13:23:20 -0400
Date: Wed, 28 Mar 2007 17:23:00 -0000
From: "Frank Ch. Eigler" <fche@redhat.com>
To: =?iso-8859-1?Q?S=E9bastien_Dugu=E9?= <sebastien.dugue@bull.net>
Cc: systemtap <systemtap@sources.redhat.com>,         Pierre PEIFFER <pierre.peiffer@bull.net>
Subject: Re: _stp_pid no longer there?
Message-ID: <20070328172320.GA26915@redhat.com>
References: <20070328120810.37633ce8@frecb000686.frec.bull.fr> <y0mabxxmouk.fsf@ton.toronto.redhat.com> <20070328173130.62b18f0b@frecb000686.frec.bull.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20070328173130.62b18f0b@frecb000686.frec.bull.fr>
User-Agent: Mutt/1.4.1i
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2007-q1/txt/msg00706.txt.bz2

Hi -

On Wed, Mar 28, 2007 at 05:31:30PM +0200, Sébastien Dugué wrote:
> [...]
> I do not use this variable directly, it's simply that some of the tapsets
> use it, namely tapset/context.stp, tapset/LKET/utils.stp and
> tapset/LKET/tskdispatch.stp.

Very good point.
 
>   Yep. I tripped it just running the testsuite.

That's reassuring, but really, we systemtap developers have been too
sloppy with adding code (functions, probes) to the tapset without (a)
documentation, and (b) test suite entries, all contrary to the
guidelines of src/HACKING.  Let's try harder to follow them.

- FChE