[Bug testsuite/4329] New: systemtap.samples/sysopen test fails on several arch's

[Bug testsuite/4329] New: systemtap.samples/sysopen test fails on several arch's

[dwilder at us dot ibm dot com]

This test is failing on x86_64, s390 and ppc64
This test case is  covered by the systemtap.syscall/openclose.c   test so maybe
it is better to just remove the sysopen test.

I looked at the test failure on s390 and ppc64.  On s390 the problem is the
script assumes that sys_open will be called by some user program but is not
providing the user program.  So it can fail in the allotted time.  On ppc64 same
problem but we it should add a probe at compat_sys_open().

-- 
           Summary: systemtap.samples/sysopen test fails on several arch's
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: dwilder at us dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4329

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/4329] systemtap.samples/sysopen test fails on several arch's

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2007-05-01 08:16 -------
In ppc64 arch, we used to see bug. 
 Reason:- src/testsuite/systemtap.samples/sysopen.exp script executes
sysopen.stp, which inturn prints how many number of files were opened in 10000
ms. Then expect script expects atleat 2 files to be opened in this time.
=============================================
[root@llm27lp1 stap_testing_200705010601]# cat
src/testsuite/systemtap.samples/sysopen.exp

set test "sysopen"
if {![installtest_p]} { untested $test; return }
spawn stap $srcdir/$subdir/sysopen.stp
set ok 0
expect {
    -timeout 60 -re {.* opened .*\r} { incr ok; exp_continue }
    timeout { fail "$test (timeout)" }
    eof { }
}
#FIXME does not handle case of hanging sysopen.stp correctly
wait
if {$ok > 1} { pass "$test ($ok)" } { fail "$test ($ok)" }
==========================================

 But in ppc64 only one file was getting opened. So we are getting this error.
===================================================
Running
/home/systemtap/tmp/stap_testing_200704300942/src/testsuite/systemtap.samples/sysopen.exp
...
irqbalance opened /proc/interrupts
FAIL: sysopen (1)
=================================
After increasing the time value for sysopen.stp from 10000 ms to 20000 ms,
sysopen.stp opens 2 files and sysopen.exp passes.
============================================
Running
/home/systemtap/tmp/stap_testing_200705010601/src/testsuite/systemtap.samples/sysopen.exp
...
irqbalance opened /proc/interrupts
irqbalance opened /proc/interrupts
PASS: sysopen (2)
=======================================

So Solution would be :- To either increase the time amount in sysopen.stp or
decrease the number of counts in sysopen.exp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4329

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/4329] systemtap.samples/sysopen test fails on several arch's

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2007-05-01 13:43 -------
The test case now expects >=1 instead of >1 opens.
It would be better if the test case included explicit
load generation though.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4329

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/4329] systemtap.samples/sysopen test fails on several arch's

[hunt at redhat dot com]

------- Additional Comments From hunt at redhat dot com  2007-05-01 16:50 -------
This test is a subset of systemtap.syscalls/openclose.
It is also poorly-coded; uses old inefficient calls, takes 10 seconds to run,
should generate its own load.

I vote to delete it. If not, replace it with something like:

probe kernel.function("sys_open") {
  printf("%s opened %s\n", execname(), user_string($filename))
}
probe begin {
  system("cat some_file")
  exit()
}



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=4329

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/4329] systemtap.samples/sysopen test fails on several arch's

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2007-05-01 16:53 -------
Kill or change it, your choice.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |hunt at redhat dot com
                   |redhat dot com              |
             Status|REOPENED                    |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=4329

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.