[Bug runtime/2224] New: comment out unnecessary spinlocks

[Bug runtime/2224] New: comment out unnecessary spinlocks

[fche at redhat dot com]

Most or all other spinlocks taken by the runtime should be unnecessary with
systemtap's generated locking code.  Please make it possible to disable all the
ones not already covered by NEED_STAT_LOCKS, like the ones in pmap/maps.

-- 
           Summary: comment out unnecessary spinlocks
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2224

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/2224] comment out unnecessary spinlocks

[hunt at redhat dot com]

------- Additional Comments From hunt at redhat dot com  2006-02-06 20:17 -------
There are no unnecessary spinlocks on maps.

The only spinlocks are per-cpu spinlocks on pmaps.  Those might be optimized out
as a later date, but are currently required and the translator need not concern
itself with internal details like this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|comment out unnecessary     |comment out unnecessary
                   |spinlocks                   |spinlocks


http://sourceware.org/bugzilla/show_bug.cgi?id=2224

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/2224] comment out unnecessary spinlocks

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2006-02-07 16:29 -------
The pmap spinlocks are unnecessary, because the translator takes
shared/exclusive locks around all pmap operations.  That should make any further
lower level locking an unnecessary overhead.  If it judges shared vs exclusive
incorrectly, that's a separate problem.

If you can justify the locks by more detailed argument, please go ahead.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=2224

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/2224] comment out unnecessary spinlocks

[hunt at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |hunt at redhat dot com
                   |redhat dot com              |
             Status|REOPENED                    |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=2224

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.