[Bug tapsets/4752] New: Error in syscall tapsets causing systemtap tests to fail.

[Bug tapsets/4752] New: Error in syscall tapsets causing systemtap tests to fail.

[srinivasa at in dot ibm dot com]

My environment is 2.6.22-rc7 kernel, systemtap-20070707 snapshot and elfutils-0.128.

Due to an error in syscall.stp(systemtap tapset), systemcall tests of
systemtap-20070707 snapshot are failing.
=========================================
semantic error: unable to find local 'utimes' near pc 0xc000000000129e6c
(alternatives: dfd filenam
e t tv): identifier '$utimes' at
/home/systemtap/tmp/stap_testing_200707090825/install/share/system
tap/tapset/syscalls.stp:945:29
Pass 2: analysis failed.  Try again with more '-v' (verbose) options.
==================================== 
In syscalls.stp
----------------------------
probe syscall.compat_futimesat = kernel.function("compat_sys_futimesat") ? {
        name = "futimesat"
        dirfd = $dfd
        filename_uaddr = $filename
        filename = user_string($filename)
        tvp_uaddr = $utimes
        argstr = sprintf("%d, %s, %s", $dfd, user_string_quoted($filename),
                _struct_compat_timeval2_u($utimes))
}
==================================================
In fs/compat.c
-------------------------------------------------
asmlinkage long compat_sys_futimesat(unsigned int dfd, char __user *filename,
struct compat_timeval __user *t)
{
        struct timespec tv[2];

        if (t) {
                if (get_user(tv[0].tv_sec, &t[0].tv_sec) ||
                    get_user(tv[0].tv_nsec, &t[0].tv_usec) ||
                    get_user(tv[1].tv_se
                    ...................
  
===================================



Solution:
========================
Since "compat_timeval __user *t" is the argument, replace "utimes" with "t". 
===========================================

-- 
           Summary: Error in syscall tapsets causing systemtap tests to
                    fail.
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: srinivasa at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4752

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/4752] Error in syscall tapsets causing systemtap tests to fail.

[hunt at redhat dot com]

------- Additional Comments From hunt at redhat dot com  2007-07-09 14:56 -------
Fix checked in.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4752

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/4752] Error in syscall tapsets causing systemtap tests to fail.

[hunt at redhat dot com]

------- Additional Comments From hunt at redhat dot com  2007-07-10 19:02 -------
*** Bug 4770 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4752

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.