From: "jkenisto at us dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/4738] UPROBES_SSOL and URETPROBES must depend on UPROBES in Kconfig
Date: Tue, 10 Jul 2007 21:01:00 -0000 [thread overview]
Message-ID: <20070710210137.23616.qmail@sourceware.org> (raw)
In-Reply-To: <20070704064428.4738.ananth@in.ibm.com>
------- Additional Comments From jkenisto at us dot ibm dot com 2007-07-10 21:01 -------
(In reply to comment #4)
...
> >
> > > this will require that we don't touch the Kconfig files,
> > > except to add CONFIG_UPROBES.
> >
> > No, it doesn't require that. See advice from Dave Hansen, appended to this
comment.
>
> I disagree. If you follow that caveat, then why aren't KRETPROBES and
> JPROBES in Kconfig?
According to Dave H, they should be.
...
> > ... But I would be willing to consider the following modifications, if
> > you'll test them and verify that (1) they do what you want and (2) SSOL and
> > uretprobes do NOT show up as choices in make *config. (I ask you cuz you've
> > already been experimenting with Kconfig changes.)
> >
> > config UPROBES_SSOL
> > bool
> > default y
> > + depends on UPROBES
> >
> > config URETPROBES
> > bool
> > default y
> > + depends on UPROBES
>
> This is precisely what I've been asking for (dependency) and have suggested
> in <b> above. I'd be happy with this change.
I'm glad you're happy with that solution. But your original email on the
subject (6/21/07 6:21 am PDT) suggested something rather different -- including
a prompt string on the "bool" line, which would cause the config options to show
up in make *config.
>
> > Note that there should be no reason for arch-specific code to test
> > CONFIG_UPROBES_SSOL or CONFIG_URETPROBES.
>
> But that is orthogonal to this issue. My main point being, if I run
> menuconfig on an arch that doesn't implement SSOL/URETPROBES, I
> shouldn't be able to set them independently of UPROBES *and* more
> importantly, they shouldn't show up if UPROBES=n.
Again (and again and again), they shouldn't show up as user-configurable options
in make *config under any circumstances.
>
> Ananth
>
I will add the indicated "depends on UPROBES" lines in the next patch set. I've
verified that they add the dependency without making the options user-configurable.
Jim
--
http://sourceware.org/bugzilla/show_bug.cgi?id=4738
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2007-07-10 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 6:44 [Bug uprobes/4738] New: " ananth at in dot ibm dot com
2007-07-07 0:16 ` [Bug uprobes/4738] " jkenisto at us dot ibm dot com
2007-07-09 4:16 ` ananth at in dot ibm dot com
2007-07-09 20:52 ` jkenisto at us dot ibm dot com
2007-07-10 4:53 ` ananth at in dot ibm dot com
2007-07-10 21:01 ` jkenisto at us dot ibm dot com [this message]
2007-07-10 21:11 ` fche at redhat dot com
2007-07-10 22:21 ` jkenisto at us dot ibm dot com
2007-07-11 0:42 ` fche at redhat dot com
2007-07-11 4:19 ` ananth at in dot ibm dot com
2007-07-11 17:25 ` jkenisto at us dot ibm dot com
2007-07-11 18:30 ` jkenisto at us dot ibm dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710210137.23616.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).