error: label 'deref_fault' used but not defined

error: label 'deref_fault' used but not defined

[Steve Dickson]

I'm getting an "label 'deref_fault' used but not defined" error
when I try to pulling the __svc_fh() function from the
/usr/share/systemtap/tapset/nfsd.stp file. I'm calling
the function from the following prob:

probe module("nfsd").function("fh_verify")
{
     printf("fh_verify: rqstp %p fhp %p type %d access %d\n",
         $rqstp, $fhp, $type, $access);
     printf("         : %s\n", __svc_fh($fhp));
}

any ideas?

Note I'm uses systemtap-0.5.14-1.fc

steved.

Re: error: label 'deref_fault' used but not defined

[Frank Ch. Eigler]

Steve Dickson <steved@4Dicksons.org> writes:

> I'm getting an "label 'deref_fault' used but not defined" error when
> I try to pulling the __svc_fh() function from the
> /usr/share/systemtap/tapset/nfsd.stp file. [...]

This was caused by a typo in the __svc_fh embedded-C function.  It
must not have been compiled before.  There are others. :-(

"Why do my eyes hurt?" - Neo
"You've never used them before." - Morpheus

- FChE

RE: error: label 'deref_fault' used but not defined

[Stone, Joshua I]

Frank Ch. Eigler wrote:
> Steve Dickson <steved@4Dicksons.org> writes:
> 
>> I'm getting an "label 'deref_fault' used but not defined" error when
>> I try to pulling the __svc_fh() function from the
>> /usr/share/systemtap/tapset/nfsd.stp file. [...]
> 
> This was caused by a typo in the __svc_fh embedded-C function.  It
> must not have been compiled before.  There are others. :-(

Ack -- fuel for Mike's fire... ;)

> "Why do my eyes hurt?" - Neo
> "You've never used them before." - Morpheus

Nice.


Josh

Re: error: label 'deref_fault' used but not defined

[Mike Mason]

Stone, Joshua I wrote:
> Frank Ch. Eigler wrote:
>> Steve Dickson <steved@4Dicksons.org> writes:
>>
>>> I'm getting an "label 'deref_fault' used but not defined" error when
>>> I try to pulling the __svc_fh() function from the
>>> /usr/share/systemtap/tapset/nfsd.stp file. [...]
>> This was caused by a typo in the __svc_fh embedded-C function.  It
>> must not have been compiled before.  There are others. :-(
> 
> Ack -- fuel for Mike's fire... ;)

Yep, thanks for helping prove my point :-)

The simple nfsd test I proposed:

	#! stap -up4
	probe nfsd.*, nfsd.*.*, nfsd.*.*.* {}

uncovers the above mentioned bug and this bug,too:

/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c: In function 
'function_clones_from_clnt':
/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c:20683: 
error: 'struct rpc_clnt' has no member named 'cl_count'
/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c: In function 
'function_tasks_from_clnt':
/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c:20704: 
error: 'struct rpc_clnt' has no member named 'cl_users'
make[1]: *** 
[/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.o] Error 1

Those bugs are fixable.  If this test had also reported 'unfixable' bugs, 
how could I have written it such that it only reported the fixable bugs?

Mike

> 
>> "Why do my eyes hurt?" - Neo
>> "You've never used them before." - Morpheus
> 
> Nice.
> 
> 
> Josh

Re: error: label 'deref_fault' used but not defined

[Frank Ch. Eigler]

Hi -

On Mon, Sep 24, 2007 at 01:02:58PM -0700, Mike Mason wrote:
> [...]
> The simple nfsd test I proposed:
> 	#! stap -up4
> 	probe nfsd.*, nfsd.*.*, nfsd.*.*.* {}
> uncovers the above mentioned bug and this bug,too:
> 
> /tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c: In function 
> 'function_clones_from_clnt':
> /tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c:20683: 
> error: 'struct rpc_clnt' has no member named 'cl_count'
> [...]

This must be a version-dependent error.


> Those bugs are fixable.  If this test had also reported 'unfixable'
> bugs, how could I have written it such that it only reported the
> fixable bugs?

Another way is to keep up-to-date the new batch of
testsuite/buildok/*-embedded.stp tests I added this morning. 
They aim to compile every embedded C function in the tapsets,
and ought to have found these two problems too.

- FChE