From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6625 invoked by alias); 4 Oct 2007 21:35:14 -0000 Received: (qmail 6613 invoked by uid 22791); 4 Oct 2007 21:35:13 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Oct 2007 21:35:09 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l94LZ7wl011906 for ; Thu, 4 Oct 2007 17:35:07 -0400 Received: from gospo.rdu.redhat.com (gospo.rdu.redhat.com [172.16.59.7]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with SMTP id l94LZ7ah010221; Thu, 4 Oct 2007 17:35:07 -0400 Received: by gospo.rdu.redhat.com (sSMTP sendmail emulation); Thu, 4 Oct 2007 17:35:07 -0400 Date: Thu, 04 Oct 2007 21:35:00 -0000 From: Andy Gospodarek To: Andy Gospodarek Cc: Martin Hunt , David Smith , Mike Mason , systemtap@sources.redhat.com Subject: Re: SystemTap on 2.6.23-rc8-mm2 Message-ID: <20071004213506.GB866@gospo.rdu.redhat.com> References: <470512D6.3010906@us.ibm.com> <47053212.6030302@redhat.com> <470547E4.8010700@redhat.com> <20071004202927.GZ866@gospo.rdu.redhat.com> <1191532251.8173.1.camel@dragon> <20071004211538.GA866@gospo.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071004211538.GA866@gospo.rdu.redhat.com> User-Agent: Mutt/1.5.10i X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00071.txt.bz2 On Thu, Oct 04, 2007 at 05:15:39PM -0400, Andy Gospodarek wrote: > On Thu, Oct 04, 2007 at 05:10:51PM -0400, Martin Hunt wrote: > > On Thu, 2007-10-04 at 16:29 -0400, Andy Gospodarek wrote: > > > On Thu, Oct 04, 2007 at 03:07:00PM -0500, David Smith wrote: > > > > David Smith wrote: > > > > >Mike Mason wrote: > > > > >>Just a heads up... I had to patch buildrun.cxx to get scripts to build > > > > >>on 2.6.23-rc8-mm2 (CFLAGS changed to KBUILD_CFLAGS, CPPFLAGS changed > > > > >>to KBUILD_CPPFLAGS). I've attached the patch below. I don't know > > > > >>when or if this change will go into Linus' kernel. I'm also not sure > > > > >>of the best way to ensure the correct CFLAGS are used in build_run.cxx > > > > >>(maybe check s.kernel_release?). > > > > > > > > > >I've seen this also (and in fact I meant to check something in but got > > > > >distracted by my other marker work). I believe my solution will be > > > > >backwards compatible to 2.6.9 kernels - I've tested it on RHEL4 but I > > > > >wanted to test f7 and RHEL5 to make sure I didn't break anything. > > > > > > > > I tested this on RHEL4, RHEL5, and f7. It seemed to work correctly > > > > everywhere so I've checked my changes. > > > > > > > > > > Interestingly I just pulled the latest sources and tried against Dave > > > Miller's net-2.6.24 tree and I'm getting the following errors: > > > > > > WARNING: ignored message of type 5 > > > > You're the second person today to remind me that warning is still in > > there. I am working on a fix. It only happens when a module is loaded > > when a systemtap script is running. > > > > Martin > > > > > > Aside from the warning it doesn't actually print my message, so the > probe isn't too helpful. ;-) OK, nevermind. I was looking at the wrong driver -- when I used one that actually calls the function I'm probing it works. Sorry for the noise....