From: "jkenisto at us dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/5163] tweak uprobes.ko build process
Date: Thu, 11 Oct 2007 23:02:00 -0000 [thread overview]
Message-ID: <20071011230153.29950.qmail@sourceware.org> (raw)
In-Reply-To: <20071011150936.5163.fche@redhat.com>
------- Additional Comments From jkenisto at us dot ibm dot com 2007-10-11 23:01 -------
(In reply to comment #0)
These are valid concerns, but I think the solutions need further thought. See
below.
One thing to keep in mind is that we don't expect uprobes.ko to be insmod-ed and
rmmod-ed every time somebody runs a stap script. Rather, once uprobes is in the
kernel, it stays there. (As mentioned in bugs #5079 and #5083, sometimes
uprobes has to hang around long after the last unregister.) The typical
scenario is that when it's time to insmod a stap-generated module, uprobes is
already in the kernel (which we can detect becauses the uprobes symbols show up
in /proc/kallsyms).
We can certainly handle somebody rmmod-ing uprobes (in which case we
automatically rebuild it and/or re-insmod it as necessary), but that's not the
typical situation.
The only times we try to build uprobes.ko are:
1. we're stopping after pass 4 (in case uprobes.ko is needed in the environment
where the script will eventually be run); or
2. we're proceeding to pass 5 and we don't see uprobes in the kernel...
... and the script needs uprobes, of course.
> We need to tweak some of the uprobes.ko build steps from bug #5079.
> Several problems: /usr/share/systemtap/runtime/uprobes is the wrong place
> to build an object file into; /usr could be read-only;
And a user from group stapdev doesn't have write access to the directory where
stap currently tries to build uprobes.ko. You'd have to run stap as root for
the build to succeed.
> the file may not be
> easily accessible to staprun except in the local/immediate probing scenario;
Yes, if you move the stap-generated module to another system, you may need to
bring uprobes.ko with it.
> uprobes.ko is kernel-version/arch. dependent, just like the systemtap probe
> module.
>
> Let's investigate building the uprobes.ko more similarly to probe modules.
>
> It could be stored in the module cache directory ($SYSTEMTAP_DIR/uprobes/).
Since each stap user has his/her own cache directory (by default), this would
mean multiple copies of uprobes.ko (and possibly the uprobes source).
> It could be given a name that encodes the version/architecture parameters
> (so the cache directory itself can be shared between machines). Instead
> of passing just "-u" to staprun and have it find uprobes.ko someplace,
> pass "UPROBEFILENAME.ko" itself in addition ot the "PROBEFILE.ko".
> "stap -p4" could itself print out both needed modules.
Jim
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=5163
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2007-10-11 23:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 15:09 [Bug uprobes/5163] New: " fche at redhat dot com
2007-10-11 23:02 ` jkenisto at us dot ibm dot com [this message]
2007-11-28 0:31 ` [Bug uprobes/5163] " jkenisto at us dot ibm dot com
2007-11-28 1:05 ` jkenisto at us dot ibm dot com
2008-12-08 18:13 ` fche at redhat dot com
2009-01-21 11:56 ` mjw at redhat dot com
2009-01-21 19:18 ` dsmith at redhat dot com
2009-01-21 19:29 ` dsmith at redhat dot com
2009-04-03 21:58 ` jistone at redhat dot com
2009-04-16 19:14 ` mjw at redhat dot com
2009-04-16 19:21 ` fche at redhat dot com
2009-04-17 18:12 ` jkenisto at us dot ibm dot com
2009-04-20 20:05 ` fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011230153.29950.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).