Re: patches to actually use markers?

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* David Smith (dsmith@redhat.com) wrote:
> Mathieu,
> 
> Thanks for the pointers, I'll take a look at your patches.

Please get the latest version then :

http://ltt.polymtl.ca/lttng/patch-2.6.23-mm1-lttng-0.10-pre11.tar.bz2

The patches I have are :

(no patch header yet)
#kernel trace thread flag
lttng-kernel-trace-thread-flag-alpha.patch
lttng-kernel-trace-thread-flag-arm.patch
lttng-kernel-trace-thread-flag-avr32.patch
lttng-kernel-trace-thread-flag-blackfin.patch
lttng-kernel-trace-thread-flag-cris.patch
lttng-kernel-trace-thread-flag-frv.patch
lttng-kernel-trace-thread-flag-h8300.patch
lttng-kernel-trace-thread-flag-i386.patch
lttng-kernel-trace-thread-flag-ia64.patch #FIXME
lttng-kernel-trace-thread-flag-m32r.patch
lttng-kernel-trace-thread-flag-m68k.patch
lttng-kernel-trace-thread-flag-m68knommu.patch
lttng-kernel-trace-thread-flag-mips.patch
lttng-kernel-trace-thread-flag-parisc.patch
lttng-kernel-trace-thread-flag-powerpc.patch
lttng-kernel-trace-thread-flag-s390.patch #FIXME
lttng-kernel-trace-thread-flag-sh.patch
lttng-kernel-trace-thread-flag-sh64.patch
lttng-kernel-trace-thread-flag-sparc.patch
lttng-kernel-trace-thread-flag-sparc64.patch
lttng-kernel-trace-thread-flag-um.patch
lttng-kernel-trace-thread-flag-v850.patch
fix-x86_64-sysenter-trace-race.patch
lttng-kernel-trace-thread-flag-x86_64.patch
lttng-kernel-trace-thread-flag-xtensa.patch
lttng-kernel-trace-thread-flag-api.patch

(with patch headers)
lttng-instrument-kernelh.patch # NOT FOR UPSTREAM
#
lttng-instrumentation-fs.patch
lttng-instrumentation-ipc.patch
lttng-instrumentation-kernel.patch
lttng-instrumentation-mm.patch
lttng-instrumentation-net.patch

And I could wait before submitting the arch specific patches I have (or
not?).  What do you think ?

lttng-instrumentation-arm.patch
lttng-instrumentation-i386.patch
lttng-instrumentation-mips.patch
lttng-instrumentation-powerpc.patch
lttng-instrumentation-ppc.patch
lttng-instrumentation-sh.patch
lttng-instrumentation-sh64.patch
lttng-instrumentation-sparc.patch
lttng-instrumentation-x86_64.patch
lttng-instrumentation-s390.patch        #FIXME: syscall trace 8 bit.

There seems to be some interest on LKML for me to submit those patches.
Early feedback would be appreciated.

Mathieu

> 
> Mathieu Desnoyers wrote:
> >* David Smith (dsmith@redhat.com) wrote:
> >>Mathieu,
> >>
> >>Now that the markers facility itself has made it in the kernel, do you 
> >>have plans on trying to send patches that actually use markers to lkml?
> >>
> >>For systemtap's use, we'd like to get some actual markers in the 
> >>upstream kernel.  Off the top of my head, we might start with adding 
> >>markers to system calls (sys_*) that contain the system call's 
> >>argument(s).
> >>
> >
> >Hi David,
> >
> >Yes, we have something similar in LTTng, we instrument many widely used
> >system calls to get the detailed arguments.
> >
> >Do you want to start having a look at my instrumentation patchset ?
> >Those are the 
> >lttng-instrumentation-*.patch patches available in the following
> >tarball:
> >
> >http://ltt.polymtl.ca/lttng/patch-2.6.23-mm1-lttng-0.10-pre8.tar.bz2
> >
> >The patches that you may find interesting to comment are :
> >
> >lttng-kernel-trace-thread-flag-*
> >  These patches adds a thread flag for kernel wide syscall trace
> >  activation.
> >  Note that I would gladly accept some help with the
> >    lttng-kernel-trace-thread-flag-ia64.patch
> >    lttng-kernel-trace-thread-flag-s390.patch
> >    lttng-instrumentation-s390.patch
> >  They need to add the 9th bit of thread flag that has to be checked by
> >  a 8 bit limited instruction on these architectures.
> >
> >lttng-instrumentation-*
> >  Actual markers. It also includes assembly code change to use the
> >  thread flags for syscall_trace.
> >  Some architectures do not have complete architecture specific marker
> >  set complete.
> >
> >It's a good thing that we start having a discussion about these marker
> >sites at this point.
> >
> >Mathieu
> >
> 
> 
> -- 
> David Smith
> dsmith@redhat.com
> Red Hat
> http://www.redhat.com
> 256.217.0141 (direct)
> 256.837.0057 (fax)

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68