From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9406 invoked by alias); 31 Oct 2007 16:58:10 -0000 Received: (qmail 9398 invoked by uid 22791); 31 Oct 2007 16:58:10 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from bc.sympatico.ca (HELO tomts22-srv.bellnexxia.net) (209.226.175.184) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 31 Oct 2007 16:58:07 +0000 Received: from toip6.srvr.bell.ca ([209.226.175.125]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071031165804.OGWT18413.tomts22-srv.bellnexxia.net@toip6.srvr.bell.ca> for ; Wed, 31 Oct 2007 12:58:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq4HALtQKEdMQWvU/2dsb2JhbACBWo5b Received: from bas5-montreal19-1279355860.dsl.bell.ca (HELO krystal.dyndns.org) ([76.65.107.212]) by toip6.srvr.bell.ca with ESMTP; 31 Oct 2007 12:56:06 -0400 Received: from localhost (localhost [127.0.0.1]) (uid 1000) by krystal.dyndns.org with local; Wed, 31 Oct 2007 12:58:03 -0400 id 002699AD.4728B41B.00001F7E Date: Wed, 31 Oct 2007 16:58:00 -0000 From: Mathieu Desnoyers To: David Smith Cc: ltt-dev@shafik.org, Systemtap List Subject: Re: patches to actually use markers? Message-ID: <20071031165803.GB4766@Krystal> References: <472633E3.1050507@redhat.com> <20071029220454.GB4233@Krystal> <4728AD5F.1010604@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <4728AD5F.1010604@redhat.com> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 12:51:40 up 93 days, 17:10, 3 users, load average: 0.54, 0.74, 0.83 User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00266.txt.bz2 * David Smith (dsmith@redhat.com) wrote: > Mathieu, > > Thanks for the pointers, I'll take a look at your patches. Please get the latest version then : http://ltt.polymtl.ca/lttng/patch-2.6.23-mm1-lttng-0.10-pre11.tar.bz2 The patches I have are : (no patch header yet) #kernel trace thread flag lttng-kernel-trace-thread-flag-alpha.patch lttng-kernel-trace-thread-flag-arm.patch lttng-kernel-trace-thread-flag-avr32.patch lttng-kernel-trace-thread-flag-blackfin.patch lttng-kernel-trace-thread-flag-cris.patch lttng-kernel-trace-thread-flag-frv.patch lttng-kernel-trace-thread-flag-h8300.patch lttng-kernel-trace-thread-flag-i386.patch lttng-kernel-trace-thread-flag-ia64.patch #FIXME lttng-kernel-trace-thread-flag-m32r.patch lttng-kernel-trace-thread-flag-m68k.patch lttng-kernel-trace-thread-flag-m68knommu.patch lttng-kernel-trace-thread-flag-mips.patch lttng-kernel-trace-thread-flag-parisc.patch lttng-kernel-trace-thread-flag-powerpc.patch lttng-kernel-trace-thread-flag-s390.patch #FIXME lttng-kernel-trace-thread-flag-sh.patch lttng-kernel-trace-thread-flag-sh64.patch lttng-kernel-trace-thread-flag-sparc.patch lttng-kernel-trace-thread-flag-sparc64.patch lttng-kernel-trace-thread-flag-um.patch lttng-kernel-trace-thread-flag-v850.patch fix-x86_64-sysenter-trace-race.patch lttng-kernel-trace-thread-flag-x86_64.patch lttng-kernel-trace-thread-flag-xtensa.patch lttng-kernel-trace-thread-flag-api.patch (with patch headers) lttng-instrument-kernelh.patch # NOT FOR UPSTREAM # lttng-instrumentation-fs.patch lttng-instrumentation-ipc.patch lttng-instrumentation-kernel.patch lttng-instrumentation-mm.patch lttng-instrumentation-net.patch And I could wait before submitting the arch specific patches I have (or not?). What do you think ? lttng-instrumentation-arm.patch lttng-instrumentation-i386.patch lttng-instrumentation-mips.patch lttng-instrumentation-powerpc.patch lttng-instrumentation-ppc.patch lttng-instrumentation-sh.patch lttng-instrumentation-sh64.patch lttng-instrumentation-sparc.patch lttng-instrumentation-x86_64.patch lttng-instrumentation-s390.patch #FIXME: syscall trace 8 bit. There seems to be some interest on LKML for me to submit those patches. Early feedback would be appreciated. Mathieu > > Mathieu Desnoyers wrote: > >* David Smith (dsmith@redhat.com) wrote: > >>Mathieu, > >> > >>Now that the markers facility itself has made it in the kernel, do you > >>have plans on trying to send patches that actually use markers to lkml? > >> > >>For systemtap's use, we'd like to get some actual markers in the > >>upstream kernel. Off the top of my head, we might start with adding > >>markers to system calls (sys_*) that contain the system call's > >>argument(s). > >> > > > >Hi David, > > > >Yes, we have something similar in LTTng, we instrument many widely used > >system calls to get the detailed arguments. > > > >Do you want to start having a look at my instrumentation patchset ? > >Those are the > >lttng-instrumentation-*.patch patches available in the following > >tarball: > > > >http://ltt.polymtl.ca/lttng/patch-2.6.23-mm1-lttng-0.10-pre8.tar.bz2 > > > >The patches that you may find interesting to comment are : > > > >lttng-kernel-trace-thread-flag-* > > These patches adds a thread flag for kernel wide syscall trace > > activation. > > Note that I would gladly accept some help with the > > lttng-kernel-trace-thread-flag-ia64.patch > > lttng-kernel-trace-thread-flag-s390.patch > > lttng-instrumentation-s390.patch > > They need to add the 9th bit of thread flag that has to be checked by > > a 8 bit limited instruction on these architectures. > > > >lttng-instrumentation-* > > Actual markers. It also includes assembly code change to use the > > thread flags for syscall_trace. > > Some architectures do not have complete architecture specific marker > > set complete. > > > >It's a good thing that we start having a discussion about these marker > >sites at this point. > > > >Mathieu > > > > > -- > David Smith > dsmith@redhat.com > Red Hat > http://www.redhat.com > 256.217.0141 (direct) > 256.837.0057 (fax) -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68