public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "jkenisto at us dot ibm dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug uprobes/5163] tweak uprobes.ko build process
Date: Wed, 28 Nov 2007 00:31:00 -0000	[thread overview]
Message-ID: <20071128003114.31422.qmail@sourceware.org> (raw)
In-Reply-To: <20071011150936.5163.fche@redhat.com>


------- Additional Comments From jkenisto at us dot ibm dot com  2007-11-28 00:31 -------
Further thoughts:

a) How about moving the uprobes source from
$(DESTDIR)/$(pkgdatadir)/runtime/uprobes to $(DESTDIR)/var/systemtap/uprobes? 
That would insure that the uprobes home lives in a writable filesystem, so
uprobes.ko can be built there.  I guess the preferred way to refer to
$(DESTDIR)/var/systemtap in Makefile.am is as
$(DESTDIR)/$(localstatedir)/var/$(PACKAGE).

b) I think it's correct that only root can build the version of uprobes.ko that
staprun insmods.  We don't want non-root users -- even users in  group stapdev
-- to mess with the uprobes source.  This also gets around some rather messy
problems that can arise if root builds uprobes.ko and then a non-root member of
stapdev tries to build it.

c) staprun will modprobe or insmod uprobes.ko, if necessary, for anybody who
invokes staprun with -u and specifies a permitted stap-generated module.  I
think this is OK.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5163

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

  parent reply	other threads:[~2007-11-28  0:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 15:09 [Bug uprobes/5163] New: " fche at redhat dot com
2007-10-11 23:02 ` [Bug uprobes/5163] " jkenisto at us dot ibm dot com
2007-11-28  0:31 ` jkenisto at us dot ibm dot com [this message]
2007-11-28  1:05 ` jkenisto at us dot ibm dot com
2008-12-08 18:13 ` fche at redhat dot com
2009-01-21 11:56 ` mjw at redhat dot com
2009-01-21 19:18 ` dsmith at redhat dot com
2009-01-21 19:29 ` dsmith at redhat dot com
2009-04-03 21:58 ` jistone at redhat dot com
2009-04-16 19:14 ` mjw at redhat dot com
2009-04-16 19:21 ` fche at redhat dot com
2009-04-17 18:12 ` jkenisto at us dot ibm dot com
2009-04-20 20:05 ` fche at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071128003114.31422.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).