From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@us.ibm.com>,
Roland McGrath <roland@redhat.com>,
Arjan van de Ven <arjan@infradead.org>,
prasanna@in.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net, systemtap-ml <systemtap@sources.redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH 3/4] x86: add kprobe-booster to X86_64
Date: Tue, 18 Dec 2007 14:00:00 -0000 [thread overview]
Message-ID: <20071218135856.GC17470@elte.hu> (raw)
In-Reply-To: <1197978160.7734.31.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> On Tue, 2007-12-18 at 12:29 +0100, Ingo Molnar wrote:
> > * Harvey Harrison <harvey.harrison@gmail.com> wrote:
> >
> > > Sorry I missed an ifdef in this patch in the following hunk:
> >
> > could you resend your kprobes cleanups against current x86.git? They
> > have been conceptually acked by Masami. This cuts out the unification
> > part of your queue which is bad luck but the effort has been duplicated
> > already so there's not much we can do about it i guess.
> >
> > Your other 17 cleanup and unification patches are still queued up in
> > x86.git and passed a lot of testing, so they will likely go into
> > v2.6.25. Nice work!
> >
> > Ingo
>
> Ingo,
>
> I'd suggest just tossing my kprobes cleanups. I just sent you a rollup
> of anything I saw that was left in mine that was still worthwhile
> after Masami's, included below for reference. It didn't amount to much
> left so I rolled it all together:
>
> Subject: [PATCH] x86: kprobes leftover cleanups
>
> Eliminate __always_inline, all of these static functions are
> only called once. Minor whitespace cleanup. Eliminate one
> supefluous return at end of void function. Reverse sense of
> #ifndef to be #ifdef to show the case only affects X86_32.
thanks, i've applied them.
Ingo
next prev parent reply other threads:[~2007-12-18 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 22:27 Harvey Harrison
2007-12-18 11:30 ` Ingo Molnar
2007-12-18 11:42 ` Harvey Harrison
2007-12-18 13:51 ` Masami Hiramatsu
2007-12-19 2:30 ` Harvey Harrison
2007-12-19 4:44 ` Masami Hiramatsu
2007-12-19 5:21 ` Harvey Harrison
2007-12-19 5:27 ` [PATCH] x86: __kprobes annotations Harvey Harrison
2007-12-19 5:43 ` Masami Hiramatsu
2007-12-19 9:28 ` Ingo Molnar
2007-12-18 14:00 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-17 21:27 [PATCH 3/4] x86: add kprobe-booster to X86_64 Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218135856.GC17470@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=prasanna@in.ibm.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).