HRTIMER_REL undefined

HRTIMER_REL undefined

[manjunath k]

Hi,

  When im trying to build the stap scripts with the HRTIMER_REL option,
an error is noticed as "HRTIMER_REL" undefined.

When the following line is commented the stap scripts start building
without an error.

"module_cflags << " += $(call stap_check_build,
$(SYSTEMTAP_RUNTIME)/autoconf-hrtimer-rel.c, -DSTAPCONF_HRTIMER_REL,)"

The runtime/autoconf-hrtimer-rel.c has the following code in it

#include <linux/hrtimer.h>
int x = HRTIMER_REL;  /* as opposed to HRTIMER_MODE_REL */

But the HRTIMER_REL is not defined in linux/hrtimer.h header file.

What is the solution for this problem ?

- Manjunath

Re: HRTIMER_REL undefined

[Srikar Dronamraju]

Whats is your kernel version and SystemTap version? 

There were changes in Kernel around 2.6.21 which made HRTIMER_REL to
HRTIMER_MODE_REL.  The versions of SystemTap later than April 2007 
should have changes to work with these kernel changes. 

Regards
Srikar

* manjunath k <kmanjunat@gmail.com> [2008-01-07 12:19:37]:

> Hi,
> 
>   When im trying to build the stap scripts with the HRTIMER_REL option,
> an error is noticed as "HRTIMER_REL" undefined.
> 
> When the following line is commented the stap scripts start building
> without an error.
> 
> "module_cflags << " += $(call stap_check_build,
> $(SYSTEMTAP_RUNTIME)/autoconf-hrtimer-rel.c, -DSTAPCONF_HRTIMER_REL,)"
> 
> The runtime/autoconf-hrtimer-rel.c has the following code in it
> 
> #include <linux/hrtimer.h>
> int x = HRTIMER_REL;  /* as opposed to HRTIMER_MODE_REL */
> 
> But the HRTIMER_REL is not defined in linux/hrtimer.h header file.
> 
> What is the solution for this problem ?
> 
> - Manjunath

Re: HRTIMER_REL undefined

[manjunath k]

Hi,

  Ive changed the HRTIMER_REL to HRTIMER_MODE_REL in the
src/runtime/autoconf-hrtimer-rel.c file and it is working fine. Is this
fix OK.

-Manjunath

On 1/7/08, Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:
>
>
>  Whats is your kernel version and SystemTap version?
>
>  There were changes in Kernel around 2.6.21 which made HRTIMER_REL to
>  HRTIMER_MODE_REL.  The versions of SystemTap later than April 2007
>  should have changes to work with these kernel changes.
>
>  Regards
>  Srikar
>
>  * manjunath k <kmanjunat@gmail.com> [2008-01-07 12:19:37]:
>
>
>  > Hi,
>  >
>  >   When im trying to build the stap scripts with the HRTIMER_REL option,
>  > an error is noticed as "HRTIMER_REL" undefined.
>  >
>  > When the following line is commented the stap scripts start building
>  > without an error.
>  >
>  > "module_cflags << " += $(call stap_check_build,
>  > $(SYSTEMTAP_RUNTIME)/autoconf-hrtimer-rel.c, -DSTAPCONF_HRTIMER_REL,)"
>  >
>  > The runtime/autoconf-hrtimer-rel.c has the following code in it
>  >
>  > #include <linux/hrtimer.h>
>  > int x = HRTIMER_REL;  /* as opposed to HRTIMER_MODE_REL */
>  >
>  > But the HRTIMER_REL is not defined in linux/hrtimer.h header file.
>  >
>  > What is the solution for this problem ?
>  >
>  > - Manjunath
>

Re: HRTIMER_REL undefined

[Frank Ch. Eigler]

"manjunath k" <kmanjunat@gmail.com> writes:

>   Ive changed the HRTIMER_REL to HRTIMER_MODE_REL in the
> src/runtime/autoconf-hrtimer-rel.c file and it is working fine. Is
> this fix OK.

Probably not: the autoconf tests are there to let the systemtap
runtime work with kernels old and new.  Maybe we need a new
autoconf-hrtimer-mode-rel.c file.

- FChE