[Bug runtime/5549] New: To make systemtap compatible with the x86/x86_64 pt_regs unification patch.

[Bug runtime/5549] New: To make systemtap compatible with the x86/x86_64 pt_regs unification patch.

[srinivasa at in dot ibm dot com]

Peter Anvin patch renames struct pt_regs members and this causes systemtap to 
break Anvin's patched kernel.
=====================================
commit 155178ca42d8529e54097704a11f1e6988bc8264
Author: H. Peter Anvin <hpa@zytor.com>
Date:   Sat Dec 22 03:03:00 2007 +0100

    x86: rename the struct pt_regs members for 32/64-bit consistency
   
    We have a lot of code which differs only by the naming of specific
    members of structures that contain registers.  In order to enable
    additional unifications, this patch drops the e- or r- size prefix
    from the register names in struct pt_regs, and drops the x- prefixes
    for segment registers on the 32-bit side.
   
    This patch also performs the equivalent renames in some additional
    places that might be candidates for unification in the future.
   
    Signed-off-by: H. Peter Anvin <hpa@zytor.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
========================================


Right now this patch is present in -mm tree and expected to be merged in 
next -rc (probably in 2.6.25-rc1) release.
So I have developed the patch which makes systemtap to work on this situation.
I have used  KERNEL_VERSION() to retain the backward compatibility of systemtap.

Please let me know your comments.

-- 
           Summary: To make systemtap compatible with the x86/x86_64 pt_regs
                    unification patch.
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: srinivasa at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5549

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5549] To make systemtap compatible with the x86/x86_64 pt_regs unification patch.

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2008-01-07 13:27 -------
Created an attachment (id=2176)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2176&action=view)
patch to solve the problem


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5549

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5549] To make systemtap compatible with the x86/x86_64 pt_regs unification patch.

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2008-01-07 21:10 -------
(In reply to comment #1)
> Created an attachment (id=2176)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2176&action=view)
> patch to solve the problem

Good work!
Could you use autoconf to check that, because this was included in -rc/-mm trees?

Here is an example:

---(runtime/autoconf-x86-uniregs.c)
#include <asm/ptrace.h>

struct pt_regs regs = {.ax = 0x0};
---
And add below line to compile_pass().(you can find similar autoconf-lines)
---
o << module_cflags << " += $(call stap_check_build,
$(SYSTEMTAP_RUNTIME)/autoconf-x86-uniregs.c, -DSTAPCONF_X86_UNIREGS,)" << endl;
---

Then, you can use #ifdef STAPCONF_X86_UNIREGS instead of KERNEL_VERSION in
runtime code.

Thank you,

-masami

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5549

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5549] To make systemtap compatible with the x86/x86_64 pt_regs unification patch.

[srinivasa at in dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |srinivasa at in dot ibm dot
                   |redhat dot com              |com
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=5549

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.