[Bug runtime/5705] New: Need more descriptive error messages on non-root systemtap invocation

[Bug runtime/5705] New: Need more descriptive error messages on non-root systemtap invocation

[ananth at in dot ibm dot com]

Currently, stap errors out on a non-root invocation with just a:

ERROR: unable to find either group "stapdev" or group "stapusr"

Though documentation pertaining to stapdev and stapusr are part of the stap(1)
manpage, IMO it is prudent to spell out a more detailed error message here.

Also, would it make sense to automagically create stapdev and stapusr groups
during systemtap install?

-- 
           Summary: Need more descriptive error messages on non-root
                    systemtap invocation
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: ananth at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-02-01 08:43 -------
Created an attachment (id=2223)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2223&action=view)
More descriptive errors on non-root stap invocation

Here is a stab at this. This or something along these lines would be good to
have.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-02-01 16:19 -------
> Here is a stab at this. This or something along these lines would be good to
> have.

Looks good.
If one can find in e.g. the fedora packaging guidelines
information to the effect of creating new groups during
.rpm installation, we can plop such code into a new
-runtime RPM %post piece.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[jkenisto at us dot ibm dot com]

------- Additional Comments From jkenisto at us dot ibm dot com  2008-02-01 17:18 -------
Created an attachment (id=2224)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2224&action=view)
More descriptive error messages on non-root stap invocation

Fixed a couple of typos and added missing punctuation.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #2223 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-02-04 09:32 -------
Thanks Jim!

I've committed Jim's version of the patch into cvs.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-02-04 13:36 -------
Created an attachment (id=2229)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2229&action=view)
create stapusr and stapdev groups if they don't exist

Adding it to the normal build process rather than %post would make sense for
users who'd want to locally build and install systemtap.

How about this totally untested patch to create the stapdev and stapusr groups
at install time. I am not too familiar with fiddling with Makefiles, but again,
something akin to what this does would be good. (The script snippet is adapted
from Tom Callaway's RPM packaging guidelines handout from Foss.in/2007).

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-02-04 13:40 -------
Created an attachment (id=2230)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2230&action=view)
Create stapusr stapdev groups if they don't exist already

Minor code reorg to accomodate comment in place

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #2229 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2008-02-04 15:06 -------
(In reply to comment #2)
> Looks good.
> If one can find in e.g. the fedora packaging guidelines
> information to the effect of creating new groups during
> .rpm installation, we can plop such code into a new
> -runtime RPM %post piece.

The fedora packaging guidelines for creating users and groups is located here:

<http://fedoraproject.org/wiki/Packaging/UsersAndGroups?highlight=%28Packaging%29>

The systemtap spec file already follows the latest fedora packaging guidelines
and creates the groups at install time.  This functionality was added on
2007-08-14.  It is done in the %pre section, like this:

  %pre
  getent group stapdev >/dev/null || groupadd -r stapdev
  getent group stapusr >/dev/null || groupadd -r stapusr
  exit 0

However, after thinking about it.  This needs to be done for the
systemtap-runtime rpm, not the main systemtap rpm.  So, the %pre section has
been moved to the systemtap-runtime rpm.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-02-05 05:30 -------
Thanks Dave

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/5705] Need more descriptive error messages on non-root systemtap invocation

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-02-05 16:03 -------
(In reply to comment #6)
> Created an attachment (id=2230)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2230&action=view)
> Create stapusr stapdev groups if they don't exist already
> Minor code reorg to accomodate comment in place

(For the record, it does not sound like a good idea to me for "make install"
to try to create system users.  Let's leave that to the packaging system, as
the committed patch does.)

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5705

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.