From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24813 invoked by alias); 25 Feb 2008 15:00:34 -0000 Received: (qmail 24800 invoked by uid 22791); 25 Feb 2008 15:00:33 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 25 Feb 2008 15:00:15 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m1PF0DIT014723; Mon, 25 Feb 2008 10:00:13 -0500 Received: from pobox-3.corp.redhat.com (pobox-3.corp.redhat.com [10.11.255.67]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1PF0Dkb026634; Mon, 25 Feb 2008 10:00:13 -0500 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.yyz.redhat.com [10.15.16.9]) by pobox-3.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1PExmEu023293; Mon, 25 Feb 2008 10:00:13 -0500 Received: from ton.toronto.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 3586F8001FF; Mon, 25 Feb 2008 09:59:32 -0500 (EST) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id m1PExFm5008975; Mon, 25 Feb 2008 09:59:15 -0500 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id m1PExFsr008974; Mon, 25 Feb 2008 09:59:15 -0500 Date: Mon, 25 Feb 2008 15:00:00 -0000 From: "Frank Ch. Eigler" To: srinivasa@in.ibm.com Cc: systemtap@sources.redhat.com Subject: changelog files, %( %) idioms Message-ID: <20080225145915.GA8718@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00319.txt.bz2 Hi - Please remember to add ChangeLog file entries for patches you commit. You committed several important fixes that only show up on careful search of cvs/git logs. Please rescan src/HACKING for guidelines, and consider retroactively adding the ChangeLog entries. Thanks for the bug #5772 patch. It is possible to make the %( kernel %) conditionals look more compact by realizing that they don't operate at the statement but at the token level. That means one can use them around just the smallest bit of code that needs to be changed for different versions/architectures, so that instead of: %( kernel_vr > "2.6.24" %? argstr = sprintf("%d, %p, %s, %p", $upid, $stat_addr, _wait4_opt_str($options), $ru) %: argstr = sprintf("%d, %p, %s, %p", $pid, $stat_addr, _wait4_opt_str($options), $ru) %) and %( kernel_vr > "2.6.24" %? pid = $upid %: pid = $pid %) one could write ... argstr = sprintf("%d, %p, %s, %p", %( kernel_vr > "2.6.24" %? $upid %: $pid %), $stat_addr, _wait4_opt_str($options), $ru) and pid = %( kernel_vr > "2.6.24" %? $upid %: $pid %) - FChE