From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28799 invoked by alias); 4 Mar 2008 04:29:45 -0000 Received: (qmail 28792 invoked by uid 22791); 4 Mar 2008 04:29:45 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Mar 2008 04:29:23 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m244SgjV003987 for ; Mon, 3 Mar 2008 23:28:42 -0500 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m244TLTa158408 for ; Mon, 3 Mar 2008 21:29:21 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m244TK1W023159 for ; Mon, 3 Mar 2008 21:29:21 -0700 Received: from thinktux.in.ibm.com ([9.124.216.66]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m244TGwX023049; Mon, 3 Mar 2008 21:29:18 -0700 Received: from thinktux.in.ibm.com (localhost.localdomain [127.0.0.1]) by thinktux.in.ibm.com (Postfix) with ESMTP id BC4B1E7920; Tue, 4 Mar 2008 09:59:48 +0530 (IST) Received: (from ananth@localhost) by thinktux.in.ibm.com (8.13.1/8.13.1/Submit) id m244Tmtm017113; Tue, 4 Mar 2008 09:59:48 +0530 Date: Tue, 04 Mar 2008 04:29:00 -0000 From: Ananth N Mavinakayanahalli To: William Cohen Cc: "Frank Ch. Eigler" , srinivasa@in.ibm.com, systemtap@sources.redhat.com Subject: Re: changelog files, %( %) idioms Message-ID: <20080304042947.GB7126@in.ibm.com> Reply-To: ananth@in.ibm.com References: <20080225145915.GA8718@redhat.com> <20080303121841.GA18212@in.ibm.com> <20080303162251.GA23898@redhat.com> <47CC2BCD.7080508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47CC2BCD.7080508@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00358.txt.bz2 On Mon, Mar 03, 2008 at 11:48:13AM -0500, William Cohen wrote: > Frank Ch. Eigler wrote: >> Hi - >> >> On Mon, Mar 03, 2008 at 05:48:41PM +0530, Ananth N Mavinakayanahalli wrote: >>> [...] >>> probe syscall.sigaltstack = kernel.function("sys_sigaltstack") { >>> name = "sigaltstack" >>> - ebx = $ebx >>> - argstr = sprintf("%p", $ebx) >>> + bx = %( kernel_vr > "2.6.24" %? $bx %: $ebx %) >>> + argstr = sprintf("%p", %( kernel_vr > "2.6.24" %? $bx %: $ebx %) ) >> >> I suggest picking a single more informative variable name than "ebx" >> or "bx" for that parameter. Then that variable could be used as the >> plain sprintf value. >> >> - FChE > > I saw this this cause failure on F-9 i686. There could be 2.6.24.1, so > probably want to check that the kernel is earlier than 2.6.25. Something > like the following: Actually, this went into 2.6.25-rc > bx = %( kernel_vr < "2.6.25" %? $bx %: $ebx %) > > Could the use of $bx be factored out of argstr, so there is only one check > for the kernel version for $ebx/$bx rather than two? How does this look? --- tapset/i686/syscalls.stp | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: systemtap-4mar/tapset/i686/syscalls.stp =================================================================== --- systemtap-4mar.orig/tapset/i686/syscalls.stp +++ systemtap-4mar/tapset/i686/syscalls.stp @@ -119,8 +119,8 @@ probe syscall.set_zone_reclaim.return = # probe syscall.sigaltstack = kernel.function("sys_sigaltstack") { name = "sigaltstack" - ebx = $ebx - argstr = sprintf("%p", $ebx) + ussp = %( kernel_vr < "2.6.25" %? $ebx %: $bx %) + argstr = sprintf("%p", ussp) } probe syscall.sigaltstack.return = kernel.function("sys_sigaltstack").return { name = "sigaltstack"