[Bug testsuite/5422] New: iostat-scsi.stp instruments function removed in 2.6.24 kernel

[Bug testsuite/5422] New: iostat-scsi.stp instruments function removed in 2.6.24 kernel

[wcohen at redhat dot com]

The iostat-scsi.stp tests fails because the sd_init_command() function is
removed from the most 2.6.24 kernel:

$  ../../install/bin/stap  -p4 ../../src/testsuite/../examples/iostat-scsi.stp 10
semantic error: no match while resolving probe point
kernel.function("sd_init_command")
Pass 2: analysis failed.  Try again with more '-v' (verbose) options.


The following URL documents the patch to driver/scsi/sd.c that causes the problem:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7f9a6bc4e9d59e7fcf03ed23f60cd81ca5d80b65

-- 
           Summary: iostat-scsi.stp instruments function removed in 2.6.24
                    kernel
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: wcohen at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[dsmith at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2007-12-05 19:28 -------
Created an attachment (id=2124)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2124&action=view)
possible fix

Here's a patch that attempts to fix this example for 2.6.24.  Note that because
of the addition of the embedded C function, you have to add '-g' to the stap
command line.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[bruno dot abinader at openbossa dot org]

------- Additional Comments From bruno dot abinader at openbossa dot org  2008-03-03 21:43 -------
The bug I'm commenting also affects iostat-scsi.stp behaviour on arm
architecture. iostat-scsi.stp fails with the following output:
$ stap -p4 iostat-scsi.stp 5 -vv
...
semantic error: no match while resolving probe point kernel.function("st_do_scsi")


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-03-04 08:25 -------
David,
Your patch in comment 2 does fix the problem. Can you please commit it?

Bruno,
I see that st_do_scsi has been around since 2005 and still exists as of today's
Linus' git. Not sure why the symbol resolution failed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ananth at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-03-05 09:39 -------
Created an attachment (id=2305)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2305&action=view)
Add -g to test script

David,
This is needed to "PASS" the test when running make check.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2008-03-05 16:41 -------
I've checked both patches in.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug testsuite/5422] iostat-scsi.stp instruments function removed in 2.6.24 kernel

[dsmith at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5422

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.