From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8988 invoked by alias); 20 Mar 2008 01:05:46 -0000 Received: (qmail 8980 invoked by uid 22791); 20 Mar 2008 01:05:46 -0000 X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from tomts5-srv.bellnexxia.net (HELO tomts5-srv.bellnexxia.net) (209.226.175.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Mar 2008 01:05:25 +0000 Received: from toip4.srvr.bell.ca ([209.226.175.87]) by tomts5-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20080320010523.YQKK1572.tomts5-srv.bellnexxia.net@toip4.srvr.bell.ca> for ; Wed, 19 Mar 2008 21:05:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmcFAPBU4UdMQWoK/2dsb2JhbACBWqh7 Received: from bas5-montreal19-1279355402.dsl.bell.ca (HELO krystal.dyndns.org) ([76.65.106.10]) by toip4.srvr.bell.ca with ESMTP; 19 Mar 2008 21:06:40 -0400 Received: from localhost (localhost [127.0.0.1]) (uid 1000) by krystal.dyndns.org with local; Wed, 19 Mar 2008 21:05:22 -0400 id 001DA2B9.47E1B852.00002216 Date: Thu, 20 Mar 2008 01:05:00 -0000 From: Mathieu Desnoyers To: Roland McGrath Cc: Wenji Huang , systemtap@sources.redhat.com Subject: Re: Bug: duplicate marker entry in Modules.marker Message-ID: <20080320010521.GA7633@Krystal> References: <20080129160005.GA5561@Krystal> <47E080D0.2030800@oracle.com> <20080319030718.82AD926F995@magilla.localdomain> <47E0C4BA.6070703@oracle.com> <20080319080227.6CC9026F9A2@magilla.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20080319080227.6CC9026F9A2@magilla.localdomain> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 21:02:24 up 19 days, 21:13, 6 users, load average: 1.81, 2.35, 3.88 User-Agent: Mutt/1.5.16 (2007-06-11) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00478.txt.bz2 * Roland McGrath (roland@redhat.com) wrote: > I modelled Module.markers generation on Module.symvers generation. > How does it deal with the problem? Is is me or they seem to detect, for each symbol, if it has changed and they overwrite the original one ? We could do the same with markers I guess. After having sorted them, we could determine, for each, if there was an entry in the original file and modify it if needed. Separate concern : I would really like to have some kind of format string coherency verification in there : when we extract the markers from a build tree, we should be able to check that all the markers with the same name have the same format string. Otherwise the incoherency will only be detected at runtime. Regards, Mathieu --=20 Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68