* [Bug tapsets/6582] New: register() needs pt_regs check
@ 2008-05-30 1:32 jkenisto at us dot ibm dot com
2008-05-30 6:48 ` [Bug tapsets/6582] " jkenisto at us dot ibm dot com
2008-05-30 7:26 ` jkenisto at us dot ibm dot com
0 siblings, 2 replies; 3+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-05-30 1:32 UTC (permalink / raw)
To: systemtap
register() and u_register() need to verify that CONTEXT->regs is not null.
(E.g., give an error message rather than an oops when register() is called from
(say) a begin probe.) Somehow this check got dropped when we moved the code
from the runtime to the tapsets. Looks like it affects i386, x86_64, and powerpc.
--
Summary: register() needs pt_regs check
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P1
Component: tapsets
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: jkenisto at us dot ibm dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=6582
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug tapsets/6582] register() needs pt_regs check
2008-05-30 1:32 [Bug tapsets/6582] New: register() needs pt_regs check jkenisto at us dot ibm dot com
@ 2008-05-30 6:48 ` jkenisto at us dot ibm dot com
2008-05-30 7:26 ` jkenisto at us dot ibm dot com
1 sibling, 0 replies; 3+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-05-30 6:48 UTC (permalink / raw)
To: systemtap
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=6582
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug tapsets/6582] register() needs pt_regs check
2008-05-30 1:32 [Bug tapsets/6582] New: register() needs pt_regs check jkenisto at us dot ibm dot com
2008-05-30 6:48 ` [Bug tapsets/6582] " jkenisto at us dot ibm dot com
@ 2008-05-30 7:26 ` jkenisto at us dot ibm dot com
1 sibling, 0 replies; 3+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-05-30 7:26 UTC (permalink / raw)
To: systemtap
------- Additional Comments From jkenisto at us dot ibm dot com 2008-05-30 00:30 -------
Fixed in git push 8437928..af26b14 today. Tested on i386 and x86_64.
Ananth, could you please verify my fix on powerpc? Here's a script that yields
an oops without the fix. You'll have to pick a different register on powerpc.
-----
probe begin {
printf("esp = %p\n", u_register("esp"))
exit()
}
-----
The reassign back to me for regression test. Thanks.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|systemtap at sources dot |ananth at in dot ibm dot com
|redhat dot com |
http://sourceware.org/bugzilla/show_bug.cgi?id=6582
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-30 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-30 1:32 [Bug tapsets/6582] New: register() needs pt_regs check jkenisto at us dot ibm dot com
2008-05-30 6:48 ` [Bug tapsets/6582] " jkenisto at us dot ibm dot com
2008-05-30 7:26 ` jkenisto at us dot ibm dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).