From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6931 invoked by alias); 11 Jun 2008 01:53:35 -0000 Received: (qmail 6893 invoked by uid 22791); 11 Jun 2008 01:53:34 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33 X-Spam-Check-By: sourceware.org Received: from e28smtp01.in.ibm.com (HELO e28esmtp01.in.ibm.com) (59.145.155.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Jun 2008 01:53:13 +0000 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by e28esmtp01.in.ibm.com (8.13.1/8.13.1) with ESMTP id m5B1r7hY005575 for ; Wed, 11 Jun 2008 07:23:07 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5B1qpc41310918 for ; Wed, 11 Jun 2008 07:22:51 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.13.1/8.13.3) with ESMTP id m5B1r6cA024281 for ; Wed, 11 Jun 2008 07:23:07 +0530 Received: from in.ibm.com ([9.126.208.202]) by d28av01.in.ibm.com (8.13.1/8.12.11) with ESMTP id m5B1qvdA024198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 11 Jun 2008 07:23:06 +0530 Date: Wed, 11 Jun 2008 14:51:00 -0000 From: "K.Prasad" To: "Stone, Joshua I" Cc: systemtap@sources.redhat.com, mmlnx@us.ibm.com Subject: Re: [Patch 2/2] Enhancements to vfs.stp (with minor modifications) Message-ID: <20080611015243.GA10821@in.ibm.com> Reply-To: prasad@linux.vnet.ibm.com References: <20080528105210.GA27784@in.ibm.com> <20080528105829.GB28111@in.ibm.com> <20080609113837.GB1810@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00613.txt.bz2 On Mon, Jun 09, 2008 at 11:10:08AM -0700, Stone, Joshua I wrote: > K.Prasad wrote: > > +function __address_inode:long (page:long) %{ /* pure */ > > + struct page *page = (struct page *)(long)THIS->page; > > + struct address_space *mapping = > > + (struct address_space *)(long)THIS; > > This typecast looks extremely suspect... Given that the same assignment sequence is done in __page_bdev without a typecast for address_space I will change the above two lines to become: + struct page *page = (struct page *)(long)THIS->page; + struct address_space *mapping = (long)THIS; Thanks, K.Prasad