From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-9140-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 7023 invoked by alias); 21 Jun 2008 10:14:33 -0000
Received: (qmail 7015 invoked by uid 22791); 21 Jun 2008 10:14:32 -0000
X-Spam-Status: No, hits=1.2 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from fgwmail7.fujitsu.co.jp (HELO fgwmail7.fujitsu.co.jp) (192.51.44.37)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 21 Jun 2008 10:14:06 +0000
Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) 	by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id m5LAD2NC019784 	(envelope-from kosaki.motohiro@jp.fujitsu.com); 	Sat, 21 Jun 2008 19:13:03 +0900
Received: from smail (m6 [127.0.0.1]) 	by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id A260C53C11F; 	Sat, 21 Jun 2008 19:13:02 +0900 (JST)
Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) 	by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 742CB24005B; 	Sat, 21 Jun 2008 19:13:02 +0900 (JST)
Received: from s2.gw.fujitsu.co.jp (s2 [127.0.0.1]) 	by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 54F86161C008; 	Sat, 21 Jun 2008 19:13:02 +0900 (JST)
Received: from fjm505.ms.jp.fujitsu.com (fjm505.ms.jp.fujitsu.com [10.56.99.83]) 	by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id F2504161C00A; 	Sat, 21 Jun 2008 19:13:01 +0900 (JST)
Received: from fjmscan502.ms.jp.fujitsu.com (fjmscan502.ms.jp.fujitsu.com [10.56.99.142])by fjm505.ms.jp.fujitsu.com with ESMTP id m5LACOIS028540; 	Sat, 21 Jun 2008 19:12:24 +0900
Received: from [127.0.0.1] ([10.124.100.179]) 	by fjmscan502.ms.jp.fujitsu.com (8.13.1/8.12.11) with ESMTP id m5LACNsI023368; 	Sat, 21 Jun 2008 19:12:24 +0900
Date: Sat, 21 Jun 2008 15:08:00 -0000
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [RFC][Patch 2/2] markers: example of irq regular kernel markers
Cc: kosaki.motohiro@jp.fujitsu.com,         Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,         Peter Zijlstra <peterz@infradead.org>,         Steven Rostedt <rostedt@goodmis.org>,         "Frank Ch. Eigler" <fche@redhat.com>, Ingo Molnar <mingo@elte.hu>,         LKML <linux-kernel@vger.kernel.org>,         systemtap-ml <systemtap@sources.redhat.com>,         Hideo AOKI <haoki@redhat.com>
In-Reply-To: <485C064E.5020705@redhat.com>
References: <20080620174529.GB10943@Krystal> <485C064E.5020705@redhat.com>
Message-Id: <20080621190132.E835.KOSAKI.MOTOHIRO@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Becky! ver. 2.42 [ja]
X-IsSubscribed: yes
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2008-q2/txt/msg00700.txt.bz2

Hi!

> > By doing so, we could leave a gcc format string check by passing the
> > format string to __mark_check_format(). We could extract the field names
> > from the prototype, so there is no need to duplicate field information
> > in the format string.
> 
> I thought that someone complained against those format strings in
> kernel code. Thus I removed it from DEFINE_TRACE.
> 
> even though, I think you can do that by adding below string table
> to LTTng module.
> 
> const char *lookup_table[MAX_MARKERS][2] = {
> {"irq_entry", "%d %d"}, // or "(int irq_id, int kernel_mode)", "%d %d"
> ...
> };

if move string to out of kernel core, compiler may kill some variable.
thus, we will get incomplete tracing result.

I think your proposal is very interesting.
but I dont understand why someone dislike format strings.
Could you explain this reason?