From: "Frank Ch. Eigler" <fche@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: systemtap-ml <systemtap@sources.redhat.com>,
Hideo AOKI <haoki@redhat.com>,
Takahiro Yasui <tyasui@redhat.com>
Subject: Re: [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers)
Date: Fri, 05 Sep 2008 16:19:00 -0000 [thread overview]
Message-ID: <20080905154426.GB20249@redhat.com> (raw)
In-Reply-To: <48C15108.6010401@redhat.com>
Hi -
On Fri, Sep 05, 2008 at 11:32:24AM -0400, Masami Hiramatsu wrote:
> Here is a patch which add $name variable access from marker probe.
> I added _stp_mark_context structure which contains .name and .format
> strings for passing both of them to marker handler. [...]
That seems unnecessary. You could have added the name/format as
separate fields, and have the embedded-C functions use
CONTEXT->marker_name / marker_format. (Those fields then better be
cleared to zero for other types of probes, and the embedded-C code
better check for that.)
- FChE
next prev parent reply other threads:[~2008-09-05 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 16:13 [Systemtap][RFC] sample test script and tapset for markers Masami Hiramatsu
2008-08-26 19:01 ` [RFC] " Frank Ch. Eigler
2008-08-26 20:19 ` Masami Hiramatsu
2008-09-05 16:19 ` [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers) Masami Hiramatsu
2008-09-05 16:19 ` Frank Ch. Eigler [this message]
2008-09-05 16:47 ` Masami Hiramatsu
2008-09-05 16:47 ` Frank Ch. Eigler
2008-09-05 23:28 ` Masami Hiramatsu
2008-09-05 16:19 ` [PATCH 2/2] marker probe: add $name testcases Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905154426.GB20249@redhat.com \
--to=fche@redhat.com \
--cc=haoki@redhat.com \
--cc=mhiramat@redhat.com \
--cc=systemtap@sources.redhat.com \
--cc=tyasui@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).