From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31086 invoked by alias); 5 Sep 2008 16:19:36 -0000 Received: (qmail 26474 invoked by uid 22791); 5 Sep 2008 15:46:01 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Sep 2008 15:45:26 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m85FjO7I026231 for ; Fri, 5 Sep 2008 11:45:24 -0400 Received: from pobox-3.corp.redhat.com (pobox-3.corp.redhat.com [10.11.255.67]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m85FjN7X022707; Fri, 5 Sep 2008 11:45:23 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.yyz.redhat.com [10.15.16.9]) by pobox-3.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m85Fix08032522; Fri, 5 Sep 2008 11:45:23 -0400 Received: from ton.toronto.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id A36FE8001FF; Fri, 5 Sep 2008 11:44:42 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id m85FiQnM023458; Fri, 5 Sep 2008 11:44:26 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id m85FiQMx023457; Fri, 5 Sep 2008 11:44:26 -0400 Date: Fri, 05 Sep 2008 16:19:00 -0000 From: "Frank Ch. Eigler" To: Masami Hiramatsu Cc: systemtap-ml , Hideo AOKI , Takahiro Yasui Subject: Re: [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers) Message-ID: <20080905154426.GB20249@redhat.com> References: <48B42A17.1080106@redhat.com> <48C15108.6010401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48C15108.6010401@redhat.com> User-Agent: Mutt/1.4.1i X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q3/txt/msg00557.txt.bz2 Hi - On Fri, Sep 05, 2008 at 11:32:24AM -0400, Masami Hiramatsu wrote: > Here is a patch which add $name variable access from marker probe. > I added _stp_mark_context structure which contains .name and .format > strings for passing both of them to marker handler. [...] That seems unnecessary. You could have added the name/format as separate fields, and have the embedded-C functions use CONTEXT->marker_name / marker_format. (Those fields then better be cleared to zero for other types of probes, and the embedded-C code better check for that.) - FChE