* [Bug runtime/6967] New: systemtap broken on s390x, compilation error
@ 2008-10-20 13:53 pmuller at redhat dot com
2008-10-20 18:24 ` [Bug runtime/6967] " jkenisto at us dot ibm dot com
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: pmuller at redhat dot com @ 2008-10-20 13:53 UTC (permalink / raw)
To: systemtap
After this commit:
commit 52333a6929a036ba787593eb42acab81d11d91b1
Author: Jim Keniston <jkenisto@us.ibm.com>
Date: Fri Oct 17 14:43:40 2008 -0700
PR6923: Make on_each_cpu() autoconf test work on old kernels.
Things became severely broken on s390x, with 2.6.18-92.el5 / 2.6.18-118.el5
kernel. (RHEL5.2 kernels). The list of testsuite regressions is too long
here :)
Stap burns down with this error:
# /usr/local/bin/stap ../testsuite/systemtap.base/ctime.stp -vv
SystemTap translator/driver (version 0.7.1/0.137 git branch (no branch), commit
52333a69)
Copyright (C) 2005-2008 Red Hat, Inc. and others
This is free software; see the source for copying conditions.
Session arch: s390x release: 2.6.18-118.el5
Created temporary directory "/tmp/stapMye1Be"
Searched '/usr/local/share/systemtap/tapset/s390x/*.stp', found 1
Searched '/usr/local/share/systemtap/tapset/*.stp', found 43
Pass 1: parsed user script and 44 library script(s) in 460usr/10sys/1220real ms.
Pass 2: analyzed script: 1 probe(s), 2 function(s), 0 embed(s), 0 global(s) in
10usr/0sys/8real ms.
Pass 3: translated to C into "/tmp/stapMye1Be/
stap_3a0a4fb7429a0207fe92ebdef2ddb987_4416.c" in 20usr/200sys/574real ms.
Running make -C "/lib/modules/2.6.18-118.el5/build" M="/tmp/stapMye1Be" modules
>/dev/null
In file included from /usr/local/share/systemtap/runtime/transport/
transport.c:20,
from /usr/local/share/systemtap/runtime/print.c:17,
from /usr/local/share/systemtap/runtime/runtime.h:84,
from /tmp/stapMye1Be/
stap_3a0a4fb7429a0207fe92ebdef2ddb987_4416.c:41:
/usr/local/share/systemtap/runtime/time.c: In function \u2018_stp_init_time
\u2019:
/usr/local/share/systemtap/runtime/time.c:243: error: too few arguments to
function \u2018on_each_cpu\u2019
make[1]: *** [/tmp/stapMye1Be/stap_3a0a4fb7429a0207fe92ebdef2ddb987_4416.o]
Error 1
make: *** [_module_/tmp/stapMye1Be] Error 2
Pass 4: compiled C into "stap_3a0a4fb7429a0207fe92ebdef2ddb987_4416.ko" in
1500usr/290sys/3739real ms.
Pass 4: compilation failed. Try again with more '-v' (verbose) options.
Running rm -rf /tmp/stapMye1Be
--
Summary: systemtap broken on s390x, compilation error
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: pmuller at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
@ 2008-10-20 18:24 ` jkenisto at us dot ibm dot com
2008-10-20 18:54 ` jkenisto at us dot ibm dot com
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-10-20 18:24 UTC (permalink / raw)
To: systemtap
------- Additional Comments From jkenisto at us dot ibm dot com 2008-10-20 18:23 -------
I think the problem is that asm-s390/irqflags.h calls typecheck() (unlike the
other asm/irqflags.h files). typecheck() is defined in linux/kernel.h. Could
you try the following fix?
In runtime/autoconf-oneachcpu-retry.c, change
#include <linux/stddef.h>
to
#include <linux/kernel.h>
Thanks.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
2008-10-20 18:24 ` [Bug runtime/6967] " jkenisto at us dot ibm dot com
@ 2008-10-20 18:54 ` jkenisto at us dot ibm dot com
2008-10-21 12:56 ` pmuller at redhat dot com
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-10-20 18:54 UTC (permalink / raw)
To: systemtap
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
2008-10-20 18:24 ` [Bug runtime/6967] " jkenisto at us dot ibm dot com
2008-10-20 18:54 ` jkenisto at us dot ibm dot com
@ 2008-10-21 12:56 ` pmuller at redhat dot com
2008-10-22 0:24 ` jkenisto at us dot ibm dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pmuller at redhat dot com @ 2008-10-21 12:56 UTC (permalink / raw)
To: systemtap
------- Additional Comments From pmuller at redhat dot com 2008-10-21 12:55 -------
Tried to make this change, rebuild and test again - seen the same error
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
` (2 preceding siblings ...)
2008-10-21 12:56 ` pmuller at redhat dot com
@ 2008-10-22 0:24 ` jkenisto at us dot ibm dot com
2008-10-22 0:30 ` jkenisto at us dot ibm dot com
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-10-22 0:24 UTC (permalink / raw)
To: systemtap
------- Additional Comments From jkenisto at us dot ibm dot com 2008-10-22 00:22 -------
Created an attachment (id=3013)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3013&action=view)
test module
Given the to-be-attached Makefile, does this module build cleanly? If not,
what are the error messages?
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
` (3 preceding siblings ...)
2008-10-22 0:24 ` jkenisto at us dot ibm dot com
@ 2008-10-22 0:30 ` jkenisto at us dot ibm dot com
2008-10-22 10:08 ` pmuller at redhat dot com
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-10-22 0:30 UTC (permalink / raw)
To: systemtap
------- Additional Comments From jkenisto at us dot ibm dot com 2008-10-22 00:28 -------
Created an attachment (id=3014)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3014&action=view)
Makefile for building test module
Given this Makefile and m6967.c, please run
$ make > log 2>&1
and post the log file. That should help us understand why
runtime/autoconf-oneachcpu-retry.c isn't compiling successfully.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
` (4 preceding siblings ...)
2008-10-22 0:30 ` jkenisto at us dot ibm dot com
@ 2008-10-22 10:08 ` pmuller at redhat dot com
2008-10-24 19:08 ` jkenisto at us dot ibm dot com
2008-10-29 0:54 ` fche at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: pmuller at redhat dot com @ 2008-10-22 10:08 UTC (permalink / raw)
To: systemtap
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
------- Additional Comments From pmuller at redhat dot com 2008-10-22 10:07 -------
That compiles cleanly. However, I've modified the Makefile generated by
systemtap do do not throw away the stap_check_build output, and I saw the
following error:
In file included from include/linux/
irqflags.h:46,
from /usr/local/share/systemtap/runtime/autoconf-oneachcpu-
retry.c:2:
include/asm/irqflags.h: In function
raw_irqs_disabled_flags:
include/asm/irqflags.h:49: error: __FLAG_SHIFT undeclared (first use in this
function)
And indeed, if I do a hack and directly include <asm/system.h> (where
__FLAGS_SHIFT is defined) to runtime/autoconf-oneachcpu-retry.c, things start
to work, and systemtap starts to work correctly.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
` (5 preceding siblings ...)
2008-10-22 10:08 ` pmuller at redhat dot com
@ 2008-10-24 19:08 ` jkenisto at us dot ibm dot com
2008-10-29 0:54 ` fche at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: jkenisto at us dot ibm dot com @ 2008-10-24 19:08 UTC (permalink / raw)
To: systemtap
------- Additional Comments From jkenisto at us dot ibm dot com 2008-10-24 19:07 -------
Created an attachment (id=3023)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3023&action=view)
proposed fix
Here's a patch that's intended to address the behaviors described so far. It
seems to work on i386 and x86_64.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug runtime/6967] systemtap broken on s390x, compilation error
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
` (6 preceding siblings ...)
2008-10-24 19:08 ` jkenisto at us dot ibm dot com
@ 2008-10-29 0:54 ` fche at redhat dot com
7 siblings, 0 replies; 9+ messages in thread
From: fche at redhat dot com @ 2008-10-29 0:54 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2008-10-29 00:53 -------
commit 68c7faf
tested on rhel5 s390x|ia64|x86_64|x86 and fedora9 x86_64
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=6967
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-10-29 0:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-20 13:53 [Bug runtime/6967] New: systemtap broken on s390x, compilation error pmuller at redhat dot com
2008-10-20 18:24 ` [Bug runtime/6967] " jkenisto at us dot ibm dot com
2008-10-20 18:54 ` jkenisto at us dot ibm dot com
2008-10-21 12:56 ` pmuller at redhat dot com
2008-10-22 0:24 ` jkenisto at us dot ibm dot com
2008-10-22 0:30 ` jkenisto at us dot ibm dot com
2008-10-22 10:08 ` pmuller at redhat dot com
2008-10-24 19:08 ` jkenisto at us dot ibm dot com
2008-10-29 0:54 ` fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).