From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21400 invoked by alias); 14 Nov 2008 00:23:02 -0000 Received: (qmail 21391 invoked by uid 22791); 14 Nov 2008 00:23:01 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp1.linux-foundation.org (HELO smtp1.linux-foundation.org) (140.211.169.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 00:22:20 +0000 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mAE0LTVP025640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Nov 2008 16:21:30 -0800 Received: from akpm.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id mAE0LS9L017712; Thu, 13 Nov 2008 16:21:29 -0800 Date: Fri, 14 Nov 2008 00:23:00 -0000 From: Andrew Morton To: Masami Hiramatsu Cc: ananth@in.ibm.com, jkenisto@us.ibm.com, davem@davemloft.net, linux-kernel@vger.kernel.org, systemtap@sources.redhat.com, rusty@rustcorp.com.au Subject: Re: [PATCH 2/7] kprobes: Add kprobe_insn_mutex and cleanup arch_remove_kprobe() Message-Id: <20081113162128.28e508ca.akpm@linux-foundation.org> In-Reply-To: <4919F175.2050009@redhat.com> References: <4919F175.2050009@redhat.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00349.txt.bz2 On Tue, 11 Nov 2008 15:56:21 -0500 Masami Hiramatsu wrote: > Add kprobe_insn_mutex for protecting kprobe_insn_pages hlist, and remove > kprobe_mutex from architecture dependent code. > > This allows us to call arch_remove_kprobe() (and free_insn_slot) while holding > kprobe_mutex. > > Signed-off-by: Masami Hiramatsu > --- > arch/arm/kernel/kprobes.c | 2 -- > arch/ia64/kernel/kprobes.c | 8 +++++--- > arch/powerpc/kernel/kprobes.c | 7 ++++--- > arch/s390/kernel/kprobes.c | 7 ++++--- > arch/x86/kernel/kprobes.c | 7 ++++--- > include/linux/kprobes.h | 1 - > kernel/kprobes.c | 25 +++++++++++++++++++++---- For some reasons sparc64 never had this mutex. You've checked that sparc64 will be OK after this change?