From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29762 invoked by alias); 18 Nov 2008 04:39:52 -0000 Received: (qmail 29708 invoked by uid 22791); 18 Nov 2008 04:39:51 -0000 X-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_W X-Spam-Check-By: sourceware.org Received: from e28smtp05.in.ibm.com (HELO e28smtp05.in.ibm.com) (59.145.155.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 04:39:07 +0000 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by e28smtp05.in.ibm.com (8.13.1/8.13.1) with ESMTP id mAI4caFg003230 for ; Tue, 18 Nov 2008 10:08:46 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAI4cQ7t3932162 for ; Tue, 18 Nov 2008 10:08:26 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.13.1/8.13.3) with ESMTP id mAI4c2jm024727 for ; Tue, 18 Nov 2008 10:08:02 +0530 Received: from linux.vnet.ibm.com (srdronam.in.ibm.com [9.124.31.43]) by d28av05.in.ibm.com (8.13.1/8.12.11) with ESMTP id mAI4c1vU024712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Nov 2008 10:08:02 +0530 Date: Tue, 18 Nov 2008 04:39:00 -0000 From: Srikar Dronamraju To: Wenji Huang Cc: systemTAP Subject: Re: [PATCH] Fix the conflicted for_each_cpu macro with 2.6.28-rc4 Message-ID: <20081118043824.GA29346@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <491D23A0.8090903@oracle.com> <492193FC.7060300@redhat.com> <49221F4F.3020905@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49221F4F.3020905@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00370.txt.bz2 * Wenji Huang [2008-11-18 09:50:07]: >>> -#ifndef for_each_cpu >>> -#define for_each_cpu(cpu) for_each_cpu_mask((cpu), cpu_possible_map) >>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28) >>> +#ifndef stp_for_each_cpu >>> +#define stp_for_each_cpu(cpu) for_each_cpu((cpu), cpu_possible_map) >>> +#endif >>> +#else >>> +#ifndef stp_for_each_cpu >>> +#define stp_for_each_cpu(cpu) for_each_cpu_mask((cpu), >>> cpu_possible_map) >>> +#endif >>> #endif Why do we use for_each_cpu_mask always instead of using for_each_cpu if its defined. That would make the code more concise. -- Srikar