From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-10464-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 12369 invoked by alias); 18 Nov 2008 05:55:04 -0000
Received: (qmail 6665 invoked by uid 48); 18 Nov 2008 05:53:44 -0000
Date: Tue, 18 Nov 2008 05:55:00 -0000
Message-ID: <20081118055344.6664.qmail@sourceware.org>
From: "wenji dot huang at oracle dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
In-Reply-To: <20081117142513.7035.fche@redhat.com>
References: <20081117142513.7035.fche@redhat.com>
Reply-To: sourceware-bugzilla@sourceware.org
Subject: [Bug translator/7035] -L mode should not suppress all errors
X-Bugzilla-Reason: AssignedTo
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2008-q4/txt/msg00372.txt.bz2


------- Additional Comments From wenji dot huang at oracle dot com  2008-11-18 05:53 -------
Current listing_mode (-l or -L) blocks all the errors. We can make -L out of
this restriction. 

stap -r /sdfijsdfoidf -l 'kernel.function("*")' will still return 0.
stap -r /sdfijsdfoidf -L 'kernel.function("*")' will print error and return 1.
stap -r /sdfijsdfoidf -ul 'kernel.function("*")' will print error and return 1.
stap -L 'kernel.function("abcdef")' will print error and return 1.

diff --git a/elaborate.cxx b/elaborate.cxx
index 7cbac31..def4846 100644
--- a/elaborate.cxx
+++ b/elaborate.cxx
@@ -1446,8 +1446,8 @@ systemtap_session::print_error (const semantic_error& e)
   string message_str[2];
   string align_semantic_error ("        ");
 
-  // NB: we don't print error messages during listing mode.
-  if (listing_mode) return;
+  // NB: we don't print error messages during listing mode -l but during -L.
+  if (listing_mode && !unoptimized) return;
 
   // We generate two messages.  The second one ([1]) is printed
   // without token compression, for purposes of duplicate elimination.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=7035

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.