From: "wenji dot huang at oracle dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug translator/7053] automatic global printing of statistic needs to check @count>0
Date: Thu, 27 Nov 2008 04:47:00 -0000 [thread overview]
Message-ID: <20081127044632.2092.qmail@sourceware.org> (raw)
In-Reply-To: <20081125191945.7053.fche@redhat.com>
------- Additional Comments From wenji dot huang at oracle dot com 2008-11-27 04:46 -------
The related code in tranlate.cxx
// PR 2142+2610: empty aggregates
3757 o->newline() << "if (unlikely (" << agg.value() << " == NULL)"
3758 << " || " << agg.value() << "->count == 0) {";
3759 o->newline(1) << "c->last_error = \"empty aggregate\";";
3760 o->newline() << "goto out;";
I can't reproduce 2142 and 2610 when such code is commented. Then
sensible result will be printed in the test case. Maybe some
improvements on global were added since that commit.
Guess we can weaken the checking of empty aggregrate.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=7053
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2008-11-27 4:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 19:20 [Bug translator/7053] New: " fche at redhat dot com
2008-11-27 4:47 ` wenji dot huang at oracle dot com [this message]
2008-11-27 16:33 ` [Bug translator/7053] " fche at redhat dot com
2008-12-02 3:36 ` wenji dot huang at oracle dot com
2008-12-02 19:20 ` fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127044632.2092.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).