From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2315 invoked by alias); 27 Nov 2008 04:47:45 -0000 Received: (qmail 2093 invoked by uid 48); 27 Nov 2008 04:46:32 -0000 Date: Thu, 27 Nov 2008 04:47:00 -0000 Message-ID: <20081127044632.2092.qmail@sourceware.org> From: "wenji dot huang at oracle dot com" To: systemtap@sources.redhat.com In-Reply-To: <20081125191945.7053.fche@redhat.com> References: <20081125191945.7053.fche@redhat.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug translator/7053] automatic global printing of statistic needs to check @count>0 X-Bugzilla-Reason: AssignedTo Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00432.txt.bz2 ------- Additional Comments From wenji dot huang at oracle dot com 2008-11-27 04:46 ------- The related code in tranlate.cxx // PR 2142+2610: empty aggregates 3757 o->newline() << "if (unlikely (" << agg.value() << " == NULL)" 3758 << " || " << agg.value() << "->count == 0) {"; 3759 o->newline(1) << "c->last_error = \"empty aggregate\";"; 3760 o->newline() << "goto out;"; I can't reproduce 2142 and 2610 when such code is commented. Then sensible result will be printed in the test case. Maybe some improvements on global were added since that commit. Guess we can weaken the checking of empty aggregrate. -- http://sourceware.org/bugzilla/show_bug.cgi?id=7053 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.