* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
@ 2008-09-19 11:17 ` srinivasa at in dot ibm dot com
2008-12-15 9:03 ` wenji dot huang at oracle dot com
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: srinivasa at in dot ibm dot com @ 2008-09-19 11:17 UTC (permalink / raw)
To: systemtap
------- Additional Comments From srinivasa at in dot ibm dot com 2008-09-19 11:16 -------
Passing invalid line number(line number greater than last line of the file) to
dwarf_getsrc_file() is causing the problem.
=================================================================
void iterate_over_srcfile_lines (char const * srcfile,
int lines[2],
bool need_single_match,
enum line_t line_type,
void (* callback) (const dwarf_line_t& line,
void * arg),
void *data)
{
Dwarf_Line **srcsp = NULL;
size_t nsrcs = 0;
dwarf_query * q = static_cast<dwarf_query *>(data);
int lineno = lines[0];
auto_free_ref<Dwarf_Line**> free_srcsp(srcsp);
get_module_dwarf();
...........................
...........................
dwarf_assert ("dwarf_getsrc_file",
dwarf_getsrc_file (module_dwarf,
srcfile, l, 0,
&srcsp, &nsrcs));
if (line_type == WILDCARD || line_type == RANGE)
{
Dwarf_Addr line_addr;
dwarf_lineno (srcsp [0], &lineno);
line_probed = lines_probed.insert(lineno);
if (lineno != l || line_probed.second == false || nsrcs > 1)
continue;
dwarf_lineaddr (srcsp [0], &line_addr);
if (dwarf_haspc (function, line_addr) != 1)
break;
}
=======================================================
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
2008-09-19 11:17 ` [Bug translator/6905] " srinivasa at in dot ibm dot com
@ 2008-12-15 9:03 ` wenji dot huang at oracle dot com
2008-12-16 17:53 ` fche at redhat dot com
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: wenji dot huang at oracle dot com @ 2008-12-15 9:03 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2008-12-15 09:02 -------
Created an attachment (id=3108)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3108&action=view)
patch for 6905
Let stap tolerate invalid line and break matching for wildcard and range case.
Meanwhile make stap smart to check line range.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
2008-09-19 11:17 ` [Bug translator/6905] " srinivasa at in dot ibm dot com
2008-12-15 9:03 ` wenji dot huang at oracle dot com
@ 2008-12-16 17:53 ` fche at redhat dot com
2008-12-17 2:50 ` wenji dot huang at oracle dot com
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: fche at redhat dot com @ 2008-12-16 17:53 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2008-12-16 17:51 -------
The patch looks plausible, but please also submit a test case and results.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
` (2 preceding siblings ...)
2008-12-16 17:53 ` fche at redhat dot com
@ 2008-12-17 2:50 ` wenji dot huang at oracle dot com
2008-12-18 23:41 ` fche at redhat dot com
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: wenji dot huang at oracle dot com @ 2008-12-17 2:50 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2008-12-17 02:49 -------
Same C file as above described.
$ gcc -g -o ex ex.c
$ stap -p2 -w -e 'probe
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") {}'
# probes
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:3") /*
pc=.absolute+0x4004cc */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:4") /*
pc=.absolute+0x4004d4 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:5") /*
pc=.absolute+0x4004db */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:6") /*
pc=.absolute+0x4004df */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:7") /*
pc=.absolute+0x4004f1 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:8") /*
pc=.absolute+0x4004f6 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:*") */
Invalid Range:
$ stap -p2 -w -e 'probe
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c: 1-2") {}'
semantic error: Starting line number for /home/wjhuang/ex.c : 3
semantic error: no match while resolving probe point
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-2")
semantic error: no probes found
Pass 2: analysis failed. Try again with another '--vp 01' option.
Excessive Range:
$ stap -p2 -w -e 'probe
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") {}'
# probes
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:3") /*
pc=.absolute+0x4004cc */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:4") /*
pc=.absolute+0x4004d4 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:5") /*
pc=.absolute+0x4004db */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:6") /*
pc=.absolute+0x4004df */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:7") /*
pc=.absolute+0x4004f1 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:8") /*
pc=.absolute+0x4004f6 */ /* <-
process("/home/wjhuang/ex").statement("main@/home/wjhuang/ex.c:1-20") */
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
` (3 preceding siblings ...)
2008-12-17 2:50 ` wenji dot huang at oracle dot com
@ 2008-12-18 23:41 ` fche at redhat dot com
2008-12-19 2:20 ` wenji dot huang at oracle dot com
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: fche at redhat dot com @ 2008-12-18 23:41 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2008-12-18 18:15 -------
Having looked into this area a bit more, it seems like we have
some major cleanup to do. See also bug #5076, bug #2475, and
even bug #6864. I'll try to reorganize this area of the code,
which should make your patch moot. Can you hold on a few weeks?
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
` (4 preceding siblings ...)
2008-12-18 23:41 ` fche at redhat dot com
@ 2008-12-19 2:20 ` wenji dot huang at oracle dot com
2009-07-27 2:38 ` wenji dot huang at oracle dot com
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: wenji dot huang at oracle dot com @ 2008-12-19 2:20 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2008-12-19 02:04 -------
np. Like to rebase on new organized code if needed.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
` (5 preceding siblings ...)
2008-12-19 2:20 ` wenji dot huang at oracle dot com
@ 2009-07-27 2:38 ` wenji dot huang at oracle dot com
2009-07-28 2:07 ` wenji dot huang at oracle dot com
2009-09-21 18:31 ` fche at redhat dot com
8 siblings, 0 replies; 10+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-07-27 2:38 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-07-27 02:38 -------
Created an attachment (id=4087)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=4087&action=view)
patch and testcase
The related code has been re-organized, but the problem still exists. The patch
has been rebased and a simple test case is provided.
Example:
$ stap -p2 -e 'probe
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*")
{print("ok")}'
# probes
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:4") /*
pc=.absolute+0x80483c4 */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:5") /*
pc=.absolute+0x80483cd */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:6") /*
pc=.absolute+0x80483d5 */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:7") /*
pc=.absolute+0x80483da */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:8") /*
pc=.absolute+0x80483ee */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:9") /*
pc=.absolute+0x80483f3 */ /* <-
process("/home/wjhuang/a.out").statement("main@/home/wjhuang/test.c:*") */
--
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3108 is|0 |1
obsolete| |
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
` (6 preceding siblings ...)
2009-07-27 2:38 ` wenji dot huang at oracle dot com
@ 2009-07-28 2:07 ` wenji dot huang at oracle dot com
2009-09-21 18:31 ` fche at redhat dot com
8 siblings, 0 replies; 10+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-07-28 2:07 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-07-28 02:07 -------
commit 1123a74ab28d4ae9f2db0d704ce3981064ed9591
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug translator/6905] process("a").statement("main@/root/a.c:*") fails by giving error message.
2008-09-19 8:48 [Bug translator/6905] New: process("a").statement("main@/root/a.c:*") fails by giving error message srinivasa at in dot ibm dot com
` (7 preceding siblings ...)
2009-07-28 2:07 ` wenji dot huang at oracle dot com
@ 2009-09-21 18:31 ` fche at redhat dot com
8 siblings, 0 replies; 10+ messages in thread
From: fche at redhat dot com @ 2009-09-21 18:31 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-09-21 18:31 -------
committed
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=6905
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 10+ messages in thread