[Bug testsuite/9699] New: 'context.exp' - test fails with 2.6.28-git3 kernel on powerpc

[Bug testsuite/9699] New: 'context.exp' - test fails with 2.6.28-git3 kernel on powerpc

[kamalesh at linux dot vnet dot ibm dot com]

While running systemtap testsuite on powerpc with 2.6.28-git3 kernel, the
'context.exp' test fails with error message 


Running /mnt/systemtap/src/testsuite/systemtap.context/context.exp ...
sourcing /mnt/systemtap/src/testsuite/systemtap.context/backtrace.tcl
ERROR: (DejaGnu) proc "2-4" does not exist.
The error code is NONE
The info on the error is:
no files matched glob pattern
"/mnt/systemtap/src/testsuite/systemtap.string/systemtap*"
    while executing
"glob /mnt/systemtap/src/testsuite/systemtap.string/systemtap*"
    invoked from within
"catch "glob ${path}/${pattern}" tmp"

# uname -a
Linux tundro5.rchland.ibm.com 2.6.28-git3-autokern1 #1 SMP Thu Jan 1 01:49:31
EST 2009 ppc64 ppc64 ppc64 GNU/Linux

# stap -V
SystemTap translator/driver (version 0.8/0.137 non-git sources)

-- 
           Summary: 'context.exp' - test fails with 2.6.28-git3 kernel on
                    powerpc
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: kamalesh at linux dot vnet dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=9699

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9699] 'context.exp' - test fails with 2.6.28-git3 kernel on powerpc

[srikar at linux dot vnet dot ibm dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 5299 bytes --]


------- Additional Comments From srikar at linux dot vnet dot ibm dot com  2009-01-01 12:16 -------
It looks like struct task_struct has in the current kernel git
http://kernel.beaverton.ibm.com/mirror/v2.6/snapshots/patch-2.6.28-git3.bz2
causing this error.

uid, gid fields are now part of struct cred.
The relevant part of the patch is 

@@ -1186,17 +1162,12 @@ struct task_struct {
 	struct list_head cpu_timers[3];
 
 /* process credentials */
-	uid_t uid,euid,suid,fsuid;
-	gid_t gid,egid,sgid,fsgid;
-	struct group_info *group_info;
-	kernel_cap_t   cap_effective, cap_inheritable, cap_permitted, cap_bset;
-	struct user_struct *user;
-	unsigned securebits;
-#ifdef CONFIG_KEYS
-	unsigned char jit_keyring;	/* default keyring to attach requested keys to */
-	struct key *request_key_auth;	/* assumed request_key authority */
-	struct key *thread_keyring;	/* keyring private to this thread */
-#endif
+	const struct cred *real_cred;	/* objective and real subjective task
+					 * credentials (COW) */
+	const struct cred *cred;	/* effective (overridable) subjective task
+					 * credentials (COW) */
+	struct mutex cred_exec_mutex;	/* execve vs ptrace cred calculation mutex */
+
 	char comm[TASK_COMM_LEN]; /* executable name excluding path
 				     - access with [gs]et_task_comm (which lock
 				       it with task_lock())


Part of the log with changes to testsuite/systemtap.context/backtrace.tcl to
spawn backtrace.stp with verbose output 


gcc -m64 -Wp,-MD,/tmp/stapIzVow7/.stap_3765391d1c7b6d45afae4ebbf24e7330_2325.o.d
 -nostdinc -isystem /usr/lib/gcc/ppc64-redhat-linux/4.1.2/include -Iinclude 
-I/usr/local/autobench/var/tmp/build/arch/powerpc/include -include
include/linux/autoconf.h -D__KERNEL__ -Iarch/powerpc -Wall -Wundef
-Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common
-Werror-implicit-function-declaration -Os -msoft-float -pipe -Iarch/powerpc
-mminimal-toc -mtraceback=none -mcall-aixdesc -mtune=power4 -mno-altivec
-mno-spe -mspe=no -funit-at-a-time -mno-string -Wa,-maltivec
-fno-stack-protector -fomit-frame-pointer -g -Wdeclaration-after-statement
-Wno-pointer-sign -Iinclude2/asm/mach-default -DSTAPCONF_X86_UNIREGS -D
"MAXSTRINGLEN=256" -freorder-blocks -Wno-unused -Werror
-I"/usr/local/share/systemtap/runtime" -DMODULE -D"KBUILD_STR(s)=#s"
-D"KBUILD_BASENAME=KBUILD_STR(stap_3765391d1c7b6d45afae4ebbf24e7330_2325)" 
-D"KBUILD_MODNAME=KBUILD_STR(stap_3765391d1c7b6d45afae4ebbf24e7330_2325)"  -S -o
/tmp/stapIzVow7/.tmp_stap_3765391d1c7b6d45afae4ebbf24e7330_2325.s
/tmp/stapIzVow7/stap_3765391d1c7b6d45afae4ebbf24e7330_2325.c^M
In file included from /usr/local/share/systemtap/runtime/transport/transport.c:23,^M
                 from /usr/local/share/systemtap/runtime/print.c:17,^M
                 from /usr/local/share/systemtap/runtime/runtime.h:84,^M
                 from
/tmp/stapIzVow7/stap_3765391d1c7b6d45afae4ebbf24e7330_2325.c:41:^M
/usr/local/share/systemtap/runtime/transport/../procfs.c: In function
‘_stp_mkdir_proc_module’:^M
/usr/local/share/systemtap/runtime/transport/../procfs.c:102: error: ‘struct
nameidata’ has no member named ‘dentry’^M
/usr/local/share/systemtap/runtime/transport/../procfs.c:103: error: implicit
declaration of function ‘path_release’^M
In file included from /usr/local/share/systemtap/runtime/transport/transport.c:35,^M
                 from /usr/local/share/systemtap/runtime/print.c:17,^M
                 from /usr/local/share/systemtap/runtime/runtime.h:84,^M
                 from
/tmp/stapIzVow7/stap_3765391d1c7b6d45afae4ebbf24e7330_2325.c:41:^M
/usr/local/share/systemtap/runtime/transport/utt.c: In function
‘utt_dropped_open’:^M
/usr/local/share/systemtap/runtime/transport/utt.c:199: error: ‘struct inode’
has no member named ‘u’^M
In file included from /usr/local/share/systemtap/runtime/print.c:17,^M
                 from /usr/local/share/systemtap/runtime/runtime.h:84,^M
                 from
/tmp/stapIzVow7/stap_3765391d1c7b6d45afae4ebbf24e7330_2325.c:41:^M
/usr/local/share/systemtap/runtime/transport/transport.c: In function
‘_stp_transport_init’:^M
/usr/local/share/systemtap/runtime/transport/transport.c:214: error: ‘struct
task_struct’ has no member named ‘uid’^M
/usr/local/share/systemtap/runtime/transport/transport.c:215: error: ‘struct
task_struct’ has no member named ‘gid’^M
make[4]: *** [/tmp/stapIzVow7/stap_3765391d1c7b6d45afae4ebbf24e7330_2325.o]
Error 1^M
make[3]: *** [_module_/tmp/stapIzVow7] Error 2^M
make[3]: Leaving directory `/usr/local/autobench/var/tmp/build'^M
Pass 4: compiled C into "stap_3765391d1c7b6d45afae4ebbf24e7330_2325.ko" in
620usr/300sys/895real ms.^M
Pass 4: compilation failed.  Try again with another '--vp 0001' option.^M
Running rm -rf /tmp/stapIzVow7^M
ERROR: (DejaGnu) proc "2-4" does not exist.




-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srikar at linux dot vnet dot
                   |                            |ibm dot com
          Component|testsuite                   |runtime


http://sourceware.org/bugzilla/show_bug.cgi?id=9699

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9699] 'context.exp' - test fails with 2.6.28-git3 kernel on powerpc

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-01-07 00:33 -------
As of commit 406d830, this seems fixed; please confirm.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=9699

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9699] 'context.exp' - test fails with 2.6.28-git3 kernel on powerpc

[kamalesh at linux dot vnet dot ibm dot com]

------- Additional Comments From kamalesh at linux dot vnet dot ibm dot com  2009-01-07 10:13 -------
(In reply to comment #2)
> As of commit 406d830, this seems fixed; please confirm.

Thanks for fixing it. I tried it on today's systemtap git
(406d830652cc659fe420dcf5b54398ea22310750). The test cases executes with some
failures.

Running /mnt/systemtap/src/testsuite/systemtap.context/context.exp ...
FAIL: backtrace of yyy_func2 (0)
FAIL: print_stack of yyy_func2 (0)
FAIL: backtrace of yyy_func3 (0)
FAIL: print_stack of yyy_func3 (0)
FAIL: backtrace of yyy_func4 (0)
FAIL: print_stack of yyy_func4 (0)
FAIL: integer function arguments -- numeric
FAIL: unsigned function arguments -- numeric
FAIL: long function arguments -- numeric
FAIL: int64 function arguments -- numeric
FAIL: char function arguments -- numeric
FAIL: string function arguments -- numeric
FAIL: integer function arguments -- numeric --kelf --ignore-dwarf
FAIL: unsigned function arguments -- numeric --kelf --ignore-dwarf
FAIL: long function arguments -- numeric --kelf --ignore-dwarf
FAIL: int64 function arguments -- numeric --kelf --ignore-dwarf
FAIL: char function arguments -- numeric --kelf --ignore-dwarf
FAIL: string function arguments -- numeric --kelf --ignore-dwarf

		=== systemtap Summary ===

# of expected passes		15
# of unexpected failures	18


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9699

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.