public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: "Frank Ch. Eigler" <fche@redhat.com>, systemtap@sources.redhat.com
Subject: Re: Discussion at Linux Foundation Japan Symposium
Date: Thu, 08 Jan 2009 09:22:00 -0000	[thread overview]
Message-ID: <20090108092237.68B01FC3E2@magilla.sf.frob.com> (raw)
In-Reply-To: Theodore Tso's message of  Tuesday, 23 December 2008 17:32:17 -0500 <20081223223217.GW23723@mit.edu>

Picking up the discussion after the holiday break.  Happy New Year.

> How much more utrace work is needed?  Fedora is shipping it, right?
> What still needs to be done before it can be merged?  The
> characterization that I heard at the plumber's conference was that the
> work was largely done, and it was just a matter of it getting merged.

It is largely done in the sense that it is a new experimental in-kernel API
that we can use now and that will surely get thrashed and refined as we go
on.  I would certainly like to see it merged sooner rather than later, and
then improved in the tree.

The code at http://people.redhat.com/roland/utrace/ and also in
git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-utrace.git
is based on the current Linus tree and can merge painlessly.

Since 2.6.2[78], the whole of the new code is utrace proper, and all under
the CONFIG_UTRACE option, which "depends on EXPERIMENTAL".  However broken
utrace might be, you can configure it out and have my patches make zero
code changes in your kernel.

I had hoped that this zero impact for the uninterested would make the
threshold of acceptance for merging utrace reasonably attainable without
much controversy or rigamarole.  However, in various recent conversations,
several kernel folks said we should not submit utrace on its own at all.
They told us a new in-kernel API can't go in without something that uses
it, and "systemtap doesn't count".  They want us to come up with some
completed kernel feature, small or large, that makes use of utrace to do
something or other, that they like and want to merge.  Only then, they
said, should we submit utrace patches, along with more patches adding this
thing that uses the utrace API.

That seems counterproductive to me, frankly.  Since you seem to be
encouraging me to just get utrace merged ASAP, I hope you agree with my
view here.  Everyone who ever says they'd like to help writing nice, useful
things based on the utrace API complains about utrace not being merged and
that this discourages work based on it.  Now other people say that it
mustn't be merged until people have done that work.  Catch 22.
(Everybody's way out is for me to just write everything, apparently.  
Silly other people want me to also work on other projects entirely at the
same time, so this idea has not been getting things done quicker.)

I agree with your attitude about bugs.  If it's merged, we will fix and
change it in the tree as we hash out problems.  People at large find it
easier to consider, test, or help work on the code that way.  It would
certainly be easier for me and for the systemtap community.  People who are
concerned it might be unstable can see "EXPERIMENTAL" when configuring
their kernels and just say "n" (CONFIG_UTRACE is off in defconfig).

Since the kernel summit I got in little time to actually do very much, so
there's really a moderately small amount of change since then.  I had fixed
several bugs and introduced more regressions along the way.  Just today I
finally got a little time to get back to it and fixed most of the
regressions, so it's not in a pathological state.  But it presently has at
least one known intermittent regression in ptrace and a WARN_ON that I'm
confused about, and I'm not certain that it can't still be crashed by some
of the test cases that LKML reviewers showed before (though our suite has
variants of those tests and I haven't seen any crashes lately).  (I'll be
spending some time on the known bugs, but a fairly constrained portion of
my time.  It still remains to be seen what can be done about getting other
hackers' eyeballs active on fixing code in this layer.)

So, please advise me.


Thanks,
Roland

  parent reply	other threads:[~2009-01-08  9:22 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-22 18:22 Frank Ch. Eigler
2008-12-22 20:38 ` Theodore Tso
2008-12-22 22:41   ` Frank Ch. Eigler
2008-12-23  0:33     ` Theodore Tso
2008-12-23  0:34       ` Masami Hiramatsu
2008-12-23  0:44         ` Theodore Tso
2008-12-23 21:13           ` Roland McGrath
2008-12-23 22:13           ` Masami Hiramatsu
2008-12-23 14:28       ` Frank Ch. Eigler
2008-12-23 22:21     ` Roland McGrath
2008-12-23 22:33       ` Masami Hiramatsu
2008-12-23 22:44         ` Roland McGrath
2008-12-24  3:40           ` Masami Hiramatsu
2008-12-24  8:48             ` Roland McGrath
2008-12-24 18:14               ` Masami Hiramatsu
2008-12-24 19:26                 ` Roland McGrath
2008-12-24 21:02                 ` Theodore Tso
2008-12-26 18:17                   ` Roland McGrath
2008-12-23 23:27       ` Theodore Tso
2008-12-24  6:11         ` Masami Hiramatsu
2009-01-10  2:48           ` Theodore Tso
2009-01-11 16:29             ` Frank Ch. Eigler
2009-01-12 18:18               ` Masami Hiramatsu
2009-01-12 18:53                 ` Frank Ch. Eigler
2009-01-12 19:29                   ` Masami Hiramatsu
2009-01-12 19:26               ` Theodore Tso
2009-01-12 20:01                 ` Frank Ch. Eigler
2009-01-12 19:05             ` Jason Baron
2009-01-12 19:52               ` Theodore Tso
2009-01-12 20:32                 ` Frank Ch. Eigler
2009-01-08  9:22         ` Roland McGrath [this message]
2009-01-10  1:33           ` Theodore Tso
2008-12-22 23:34   ` Masami Hiramatsu
  -- strict thread matches above, loose matches on Subject: below --
2008-12-18  8:33 Satoshi OSHIMA
2008-12-18  8:59 ` KOSAKI Motohiro
2008-12-18  9:07 ` Jun Koi
2008-12-18  9:21   ` jidong xiao
2008-12-18  9:28     ` Jun Koi
2008-12-18  9:35   ` KOSAKI Motohiro
2008-12-18  9:37     ` Jun Koi
2008-12-18  9:42       ` Jun Koi
2008-12-18  9:46         ` KOSAKI Motohiro
2008-12-18  9:58     ` K.Prasad
2008-12-18 10:02       ` KOSAKI Motohiro
2008-12-18 10:21         ` K.Prasad
2008-12-18 15:52         ` Masami Hiramatsu
2008-12-18 15:41 ` Masami Hiramatsu
2008-12-18 17:11 ` Frank Ch. Eigler
2008-12-19  0:08   ` KOSAKI Motohiro
2008-12-19  0:58     ` Frank Ch. Eigler
2008-12-19  1:39       ` KOSAKI Motohiro
2008-12-19 23:51       ` William Cohen
2008-12-20  1:51         ` Richard J Moore
2008-12-20 14:27         ` Masami Hiramatsu
2008-12-19  0:45   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108092237.68B01FC3E2@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=fche@redhat.com \
    --cc=systemtap@sources.redhat.com \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).