[Bug runtime/9821] New: Support strftime like format for output file

[Bug runtime/9821] New: Support strftime like format for output file

[mhiramat at redhat dot com]

Support the subset of strftime(3) for output file name, like below.
$ stap foo.stp -o foo-%F-%T.log 

With the on-file flight recorder mode, this feature is useful for checking
creation time of the logfile without looking into it.

-- 
           Summary: Support strftime like format for output file
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: mhiramat at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-02-04 22:43 -------
Created an attachment (id=3719)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3719&action=view)
[PATCH][depend 6930] staprun supports subset of strftime.

This patch adds strftime like format support for output file name to systemtap.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |6930


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-03-20 01:16 -------
Looks OK.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-03-20 19:33 -------
patch committed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

-- 
Bug 9821 depends on bug 6930, which changed state.

Bug 6930 Summary: Flight Recorder on file
http://sourceware.org/bugzilla/show_bug.cgi?id=6930

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[fche at redhat dot com]

-- 
Bug 9821 depends on bug 6930, which changed state.

Bug 6930 Summary: Flight Recorder on file
http://sourceware.org/bugzilla/show_bug.cgi?id=6930

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-04-02 15:01 -------
Created an attachment (id=3865)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3865&action=view)
[PATCH][BUGFIX] fix strftime formatting

The results of %C, %l and %j have not fitted the output of date command. This
patch fixes this problem.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-04-02 23:53 -------
(In reply to comment #5)
> Created an attachment (id=3865)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3865&action=view)
> [PATCH][BUGFIX] fix strftime formatting
> 
> The results of %C, %l and %j have not fitted the output of date command. This
> patch fixes this problem.

Why are we taking a subset of strftime and implementing it ourselves?  Couldn't
we just use the real strftime(3) and be done with it?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-04-03 00:41 -------
(In reply to comment #6)
> Why are we taking a subset of strftime and implementing it ourselves?  Couldn't
> we just use the real strftime(3) and be done with it?

Good question :-). When I tried to use strftime(), compiler warned me that I
passed non-constant string for *fmt (I think strftime doesn't need compile-time
checking...),
and I couldn't build stapio.
Would you know how to suppress it?


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-04-04 00:40 -------
(In reply to comment #7)
> Would you know how to suppress it?

You can add -fno-builtin-strftime to stapio_CFLAGS.  We don't use strftime
anywhere else, so this should be fine.

(I'm assuming that you'd also move the strftime() calls out of common.c, since
staprun doesn't need it)

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-04-18 04:03 -------
Created an attachment (id=3890)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3890&action=view)
[PATCH] stapio: use genuine strftime

OK, here is a patch which use glibc's strftime.

I left stap_strfloctime in common.c due to filename format/length checking.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-04-18 04:05 -------
Created an attachment (id=3891)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3891&action=view)
[PATCH] Add testcases for strftime

This patch adds a testcase for strftime filename.The test compares filename
with output of date(3).

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-04-22 16:50 -------
> [PATCH] stapio: use genuine strftime
> [PATCH] Add testcases for strftime

Ship it!

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

------- Additional Comments From mhiramat at redhat dot com  2009-04-22 17:26 -------
(In reply to comment #11)
> > [PATCH] stapio: use genuine strftime
> > [PATCH] Add testcases for strftime
> 
> Ship it!

Done!

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9821] Support strftime like format for output file

[mhiramat at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|6930                        |


http://sourceware.org/bugzilla/show_bug.cgi?id=9821

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.