From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3423 invoked by alias); 5 Feb 2009 18:02:00 -0000 Received: (qmail 3393 invoked by uid 22791); 5 Feb 2009 18:01:58 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=BAYES_50 X-Spam-Check-By: sourceware.org Received: from kroah.org (HELO coco.kroah.org) (198.145.64.141) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Feb 2009 18:01:50 +0000 Received: from localhost (c-76-105-230-205.hsd1.or.comcast.net [76.105.230.205]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id 0753649018; Thu, 5 Feb 2009 10:01:45 -0800 (PST) Date: Thu, 05 Feb 2009 19:02:00 -0000 From: Greg KH To: Jason Baron Cc: linux-kernel@vger.kernel.org, gnb@sgi.com, gregkh@suse.de, nfsv4@linux-nfs.org, systemtap@sources.redhat.com Subject: Re: [Patch 0/2] dynamic debug Message-ID: <20090205175849.GA936@kroah.com> References: <20090205164520.GB3114@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090205164520.GB3114@redhat.com> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q1/txt/msg00363.txt.bz2 On Thu, Feb 05, 2009 at 11:45:20AM -0500, Jason Baron wrote: > hi, > > This patchset combines Greg Bank's dprintk() patchset with the dynamic printk > patchset. We are renaming the combined solution 'dynamic debug'. As a reminder, > the patchset allows debug printk style statements to be dynamically > enabled/disabled at runtime. > > The key new feature of this patchset is a richer /debugfs control file > interface, (an example output from my system is at the bottom), which allows > fined grained control over the the debug output. The output can be controlled by > function, file and line number, module, and format string. That's nice, but do we really need to have that kind of control? It seems like overkill. > For example, to enable all debug statement in module 'nf_conntrack': > > #echo -n 'module nf_conntrack +p' > /mnt/debugfs/dynamic_debug/control > > A further explanation can be found in the documentation patch. > > While adding these new features we have dropped a couple that we intend to add > back in subsequent patches. The ability to turn on/off all debugging at once, > either via the /debugfs control file, or via the kernel command line. > > thanks, > > -Jason and Greg > > > # filename:lineno [module]function flags format > arch/x86/kernel/setup_percpu.c:260 [setup_percpu]numa_set_node - "Setting\040node\040for\040non-present\040cpu\040%d\012" Why the \040 syntax? Can't we handle a space in a string? Makes it very hard to grep for things... I'll give these a spin in my tree to see how it works for now. thanks, greg k-h