[Bug runtime/9850] New: dtrace: Incorrect shell execution

[Bug runtime/9850] New: dtrace: Incorrect shell execution

[eugen at debian dot org]

dtrace -G uses shell to execute gcc:

    call("gcc -fPIC -c " + fn + " -o " + filename, shell=True)

This makes directories with spaces problematic:

% mkdir a\ directory
% cd a\ directory
% touch test.d
% ../dtrace -G -s $PWD/test.d
gcc: directory/test.o: No such file or directory

Better way is to use python equivalent of execlp(3) or execvp(3).

-- 
           Summary: dtrace: Incorrect shell execution
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: eugen at debian dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=9850

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9850] dtrace: Incorrect shell execution

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-02-16 13:54 -------
I made it so that call passes a list of arguments so that spaces aren't a
problem in:

commit c0d0d86876a3763492b3f4054961e9c850e9c216
Author: Mark Wielaard <mjw@redhat.com>
Date:   Mon Feb 16 14:50:02 2009 +0100

    PR 9850, use a list of arguments for call.

But you will still have to quote things like $PWD on the command line to get
them as whole arguments to python (otherwise the shell seems to split them into
multiple arguments anyway). So using this now works:
../dtrace -G -s "$PWD/test.d"
as does
../dtrace -G -s ../a\ directory/test.d

Is this enough?

I am not sure how to get the behaviour you want without quoting the $PWD
variable in the shell.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9850

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9850] dtrace: Incorrect shell execution

[eugen at debian dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]


------- Additional Comments From eugen at debian dot org  2009-02-16 14:18 -------
Subject: Re:  dtrace: Incorrect shell execution

16 лютого 2009 о 13:54 -0000 mjw at redhat dot com написав(-ла):
> But you will still have to quote things like $PWD on the command line to get
> them as whole arguments to python (otherwise the shell seems to split them into
> multiple arguments anyway).
Hmm, not my shell (zsh)... But others realy do so.

> So using this now works:
> ../dtrace -G -s "$PWD/test.d"
> as does
> ../dtrace -G -s ../a\ directory/test.d
> 
> Is this enough?
Yep, this is enough.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9850

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9850] dtrace: Incorrect shell execution

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-02-16 14:21 -------
It is enough! :)

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=9850

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.