[Bug runtime/9860] New: _stp_stack_print_fallback prototype/function declaration mismatch

[Bug runtime/9860] New: _stp_stack_print_fallback prototype/function declaration mismatch

[wcohen at redhat dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

The tests fail to build on i386 machines because of a mismatch between
declaration and the actual function:

For example

stap -vv systemtap.base/array_size.stp

produces the following error:

In file included from /usr/share/systemtap/runtime/stack.c:42,
                 from /tmp/stapxtSatU/stap_6695.c:43:
/usr/share/systemtap/runtime/stack-i386.c:19: error: conflicting types for
‘_stp_stack_print_fallback’
/usr/share/systemtap/runtime/stack.c:35: error: previous declaration of
‘_stp_stack_print_fallback’ was here

-- 
           Summary: _stp_stack_print_fallback prototype/function declaration
                    mismatch
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: wcohen at redhat dot com
  GCC host triplet: i686


http://sourceware.org/bugzilla/show_bug.cgi?id=9860

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9860] _stp_stack_print_fallback prototype/function declaration mismatch

[wcohen at redhat dot com]

------- Additional Comments From wcohen at redhat dot com  2009-02-18 04:52 -------
Created an attachment (id=3749)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3749&action=view)
Remove context parameter from _stp_stack_print_fallback()


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9860

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9860] _stp_stack_print_fallback prototype/function declaration mismatch

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-02-18 12:21 -------
What is the consequence of dropping the "_stp_valid_stack_ptr()" check?


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9860

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9860] _stp_stack_print_fallback prototype/function declaration mismatch

[wcohen at redhat dot com]

------- Additional Comments From wcohen at redhat dot com  2009-02-18 13:48 -------
The previous i386 test was stricter, only allowing accessing to the kernel stack
region. The change for stack-i386.c mirrors the code in stack-x86_64.c. This
question was on my mind too, and I wanted some review of it before the change
was checked in.

The is a check using _stp_read_address() to test whether accessing the address
is going to cause a fault and the code returns if unable to access.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9860

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/9860] _stp_stack_print_fallback prototype/function declaration mismatch

[wcohen at redhat dot com]

------- Additional Comments From wcohen at redhat dot com  2009-02-18 18:36 -------
Built rpms from the git checkout with the stack-i386.c patch and ran the tests
on RHEL5 i386 machine. The test results look much more reasonable.

		=== systemtap Summary ===

# of expected passes		627
# of unexpected failures	5
# of unexpected successes	8
# of expected failures		201
# of unknown successes		1
# of known failures		6
# of untested testcases		4
# of unsupported tests		2


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=9860

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.