[Bug tapsets/9896] New: Systemtap source compilation failure on latest Ubuntu

[Bug tapsets/9896] New: Systemtap source compilation failure on latest Ubuntu

[ankita at in dot ibm dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

When compiling the latest systemtap tarball, v 0;9 with 0.140 elfutils package,
gives the following compile time warning:

tapsets.cxx: In member function ‘std::string
dwflpp::express_as_string(std::string, std::string, location*)’:
tapsets.cxx:2299: error: format not a string literal and no format arguments
tapsets.cxx:2301: error: format not a string literal and no format arguments

Since the Makefile passes the -Werror flag, warnings are treated as errors and
the compilation aborts.

This was seen on a x86_64 system on Ubuntu Intrepid (8.10), running 2.6.29-rc4
kernel, with gcc version 4.3.2.

-- 
           Summary: Systemtap source compilation failure on latest Ubuntu
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: ankita at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=9896

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9896] Systemtap source compilation failure on latest Ubuntu

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-02-25 09:50 -------
(In reply to comment #1)
> The following patch fixes the problem for Ankita. Do we want this fix or is
> removing -Werror preferred?

IMHO we want this fix and keep -Werror, it catches important stuff.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9896

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9896] Systemtap source compilation failure on latest Ubuntu

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2009-02-25 09:35 -------
The following patch fixes the problem for Ankita. Do we want this fix or is
removing -Werror preferred?

---
 tapsets.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: systemtap-20feb/tapsets.cxx
===================================================================
--- systemtap-20feb.orig/tapsets.cxx
+++ systemtap-20feb/tapsets.cxx
@@ -2296,9 +2296,9 @@ struct dwflpp
     assert(memstream);
 
     fprintf(memstream, "{\n");
-    fprintf(memstream, prelude.c_str());
+    fprintf(memstream, "%s", prelude.c_str());
     bool deref = c_emit_location (memstream, head, 1);
-    fprintf(memstream, postlude.c_str());
+    fprintf(memstream, "%s", postlude.c_str());
     fprintf(memstream, "  goto out;\n");
 
     // dummy use of deref_fault label, to disable warning if deref() not used


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9896

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9896] Systemtap source compilation failure on latest Ubuntu

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-02-25 09:52 -------
*** Bug 9898 has been marked as a duplicate of this bug. ***

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9896

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9896] Systemtap source compilation failure on latest Ubuntu

[ananth at in dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |ananth at in dot ibm dot com
                   |redhat dot com              |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=9896

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.