public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug translator/9932] New: @cast module search path
@ 2009-03-07 23:19 fche at redhat dot com
  2009-03-09 22:27 ` [Bug translator/9932] " mjw at redhat dot com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: fche at redhat dot com @ 2009-03-07 23:19 UTC (permalink / raw)
  To: systemtap

Related to bug #2067, with @cast() now taking a module name argument,
we can fail to process a @cast() if the type named was only defined in
a module rather than core vmlinux.  e.g. rhel5 scsi_device, as in the
newly failing buildok/scsi* tests.

So perhaps @cast could grow a search-path facility:
   @cast(value, "scsi_device", "kernel:scsi_mod")

-- 
           Summary: @cast module search path
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com
OtherBugsDependingO 9871
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=9932

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug translator/9932] @cast module search path
  2009-03-07 23:19 [Bug translator/9932] New: @cast module search path fche at redhat dot com
@ 2009-03-09 22:27 ` mjw at redhat dot com
  2009-03-10  2:17 ` mjw at redhat dot com
  2009-03-11 16:46 ` jistone at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: mjw at redhat dot com @ 2009-03-09 22:27 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From mjw at redhat dot com  2009-03-09 21:03 -------
Same is necessary for the new rpc code after:

commit fb3b52a7346202fea1905ed680a3256d372a7b03
Author: Wenji Huang <wenji.huang@oracle.com>
Date:   Fri Mar 6 00:16:50 2009 -0500

    PR9871: use @cast in tapset
    
    Rewrite some functions using type casting to
    get rid of embedded C code in nfs, scsi, signal,
    socket, rpc, task and vfs tapset.
    
    Signed-off-by: Wenji Huang <wenji.huang@oracle.com>

This results in failing tests like:

starting /home/mark/src/systemtap/testsuite/buildok/rpc-embedded.stp
spawn1 stap -p4 /home/mark/src/systemtap/testsuite/buildok/rpc-embedded.stp
semantic error: type definition not found: identifier '@cast' at
/usr/local/systemtap/share/systemtap/tapset/rpc.stp:974:14^M
semantic error: type definition not found: identifier '@cast' at
/usr/local/systemtap/share/systemtap/tapset/rpc.stp:974:14^M
        source:                 rpc_proc = @cast(msg, "rpc_message",
"kernel")->rpc_proc^M

Because on my system sunrpc is compiled as a module.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9932

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug translator/9932] @cast module search path
  2009-03-07 23:19 [Bug translator/9932] New: @cast module search path fche at redhat dot com
  2009-03-09 22:27 ` [Bug translator/9932] " mjw at redhat dot com
@ 2009-03-10  2:17 ` mjw at redhat dot com
  2009-03-11 16:46 ` jistone at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: mjw at redhat dot com @ 2009-03-10  2:17 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From mjw at redhat dot com  2009-03-09 21:05 -------
Created an attachment (id=3805)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3805&action=view)
Temporary fix/workaround patch for sunrpc as module


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9932

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug translator/9932] @cast module search path
  2009-03-07 23:19 [Bug translator/9932] New: @cast module search path fche at redhat dot com
  2009-03-09 22:27 ` [Bug translator/9932] " mjw at redhat dot com
  2009-03-10  2:17 ` mjw at redhat dot com
@ 2009-03-11 16:46 ` jistone at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: jistone at redhat dot com @ 2009-03-11 16:46 UTC (permalink / raw)
  To: systemtap


------- Additional Comments From jistone at redhat dot com  2009-03-10 17:52 -------
In the future we may want to expand this to all module-searching components, but
for now I'll work on adding it for @cast.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |jistone at redhat dot com
                   |redhat dot com              |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=9932

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-03-10 17:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-07 23:19 [Bug translator/9932] New: @cast module search path fche at redhat dot com
2009-03-09 22:27 ` [Bug translator/9932] " mjw at redhat dot com
2009-03-10  2:17 ` mjw at redhat dot com
2009-03-11 16:46 ` jistone at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).