public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Josh Stone <jistone@redhat.com>
Cc: "Frank Ch. Eigler" <fche@redhat.com>,
	        Prerna Saxena <prerna@linux.vnet.ibm.com>,
	systemtap@sourceware.org
Subject: Re: [RFC][PATCH 1/4] kprobe-based symbol resolution for 	stap-translator
Date: Mon, 16 Mar 2009 07:01:00 -0000	[thread overview]
Message-ID: <20090316052054.GC3917@in.ibm.com> (raw)
In-Reply-To: <49BACA2C.1050108@redhat.com>

On Fri, Mar 13, 2009 at 02:03:40PM -0700, Josh Stone wrote:
> Frank Ch. Eigler wrote:
>> - and then some new intelligence in the translator that automatically
>>   downgrades "kernel.function("...")' probes to 'kernel.kprobe("...")'
>>   if the probe point & handler does not appear to require debuginfo
>
> This downgrade could only occur for .call variants, right?  A plain 
> 'kernel.function("...")' could exist as both a standalone function and as 
> an inline instance if gcc is being clever...

Yes, kallsyms_lookup_name() works only with .call. It can and will return
only one address per symbol; it won't even resolve compiler inlined
instances (many of the signal tapset failures are a result of such
inlining).

> I'm leery even of this though, because it seems there's no way to validate 
> the function name until you actually run it, right?

I think that fear is an unfounded; as mentioned before, if there are
namespace clashes, the first 'found' instance is what gets returned. Sure,
there can be bugs in the kallsyms' function name resolution. That'd be a
kernel bug and can be fixed.

Ananth

  parent reply	other threads:[~2009-03-16  5:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13 10:44 Prerna Saxena
2009-03-13 10:58 ` [RFC][PATCH 2/4] " Prerna Saxena
2009-03-13 12:13 ` [RFC][PATCH 3/4] " Prerna Saxena
2009-03-13 12:30 ` [RFC][PATCH 4/4] " Prerna Saxena
2009-03-13 16:10 ` [RFC][PATCH 1/4] " Frank Ch. Eigler
2009-03-13 18:23   ` Ananth N Mavinakayanahalli
2009-03-13 21:04     ` Frank Ch. Eigler
2009-03-13 22:10       ` Josh Stone
2009-03-13 23:13         ` Frank Ch. Eigler
2009-03-16  7:01         ` Ananth N Mavinakayanahalli [this message]
2009-03-16 21:59           ` Josh Stone
2009-04-09 16:22       ` Frank Ch. Eigler
2009-04-13 15:07         ` Prerna Saxena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090316052054.GC3917@in.ibm.com \
    --to=ananth@in.ibm.com \
    --cc=fche@redhat.com \
    --cc=jistone@redhat.com \
    --cc=prerna@linux.vnet.ibm.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).