From: "jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug translator/10054] improve $expr->foo->bar->zoo error messages
Date: Thu, 16 Apr 2009 16:21:00 -0000 [thread overview]
Message-ID: <20090416162057.4591.qmail@sourceware.org> (raw)
In-Reply-To: <20090410173925.10054.fche@redhat.com>
------- Additional Comments From jistone at redhat dot com 2009-04-16 16:20 -------
(In reply to comment #1)
> Created an attachment (id=3887)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3887&action=view)
> first stage patch
>
> With the patch, the correct local variable name will be focused instead of
> top one.
[...]
> 'foo' replaces the previous 'file'. And the remains parts are "identifier
> $file" and the position of "^". Seems not easy to change them since they are
> from e->tok.
This is a good first step. However, I would rather see an error "unable to find
member ..." generated at the point of failure. We should just make the mode of
translate_components be succeed-or-throw, and then the callers can be simpler.
For getting the right token, I would suggest changing the components vector's
element-type into a real struct (instead of just a std::pair), and then the
parsing token can be saved there.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=10054
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2009-04-16 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 17:39 [Bug translator/10054] New: " fche at redhat dot com
2009-04-16 9:41 ` [Bug translator/10054] " wenji dot huang at oracle dot com
2009-04-16 15:37 ` fche at redhat dot com
2009-04-16 16:21 ` jistone at redhat dot com [this message]
2009-05-09 1:50 ` jistone at redhat dot com
2010-04-28 22:14 ` jistone at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416162057.4591.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).