From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-12225-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 15471 invoked by alias); 29 Apr 2009 09:26:45 -0000
Received: (qmail 15464 invoked by uid 22791); 29 Apr 2009 09:26:44 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from e38.co.us.ibm.com (HELO e38.co.us.ibm.com) (32.97.110.159)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Apr 2009 09:26:40 +0000
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) 	by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3T9O5fs019569 	for <systemtap@sourceware.org>; Wed, 29 Apr 2009 03:24:05 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) 	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3T9QbA9018428 	for <systemtap@sourceware.org>; Wed, 29 Apr 2009 03:26:37 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) 	by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3T9Qahg030695 	for <systemtap@sourceware.org>; Wed, 29 Apr 2009 03:26:36 -0600
Received: from thinktux.in.ibm.com ([9.124.31.25]) 	by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3T9QZcA030647; 	Wed, 29 Apr 2009 03:26:36 -0600
Received: by thinktux.in.ibm.com (Postfix, from userid 500) 	id 0F574267B4; Wed, 29 Apr 2009 14:56:34 +0530 (IST)
Date: Wed, 29 Apr 2009 09:26:00 -0000
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Mark Wielaard <mjw@redhat.com>
Cc: Pavan Naregundi <pavan.naregundi@in.ibm.com>, systemtap@sourceware.org
Subject: Re: Systemtap snap:b6371390 test on kernel 2.6.30-rc3-git2
Message-ID: <20090429092634.GA3411@in.ibm.com>
Reply-To: ananth@in.ibm.com
References: <OF427B251C.86F0F551-ON652575A5.00402B4D-652575A5.0040F12A@in.ibm.com> <1240843370.4387.45.camel@fedora.wildebeest.org> <20090428065617.GD1531@in.ibm.com> <1240995422.2389.2.camel@fedora.wildebeest.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1240995422.2389.2.camel@fedora.wildebeest.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-IsSubscribed: yes
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2009-q2/txt/msg00469.txt.bz2

On Wed, Apr 29, 2009 at 10:57:01AM +0200, Mark Wielaard wrote:
> On Tue, 2009-04-28 at 12:26 +0530, Ananth N Mavinakayanahalli wrote:
> > On Mon, Apr 27, 2009 at 04:42:50PM +0200, Mark Wielaard wrote:
> > > On Mon, 2009-04-27 at 17:17 +0530, Pavan Naregundi wrote:
> > > > Results of systemtap snap:b6371390 test on kernel 2.6.30-rc3-git2
> > > > Arch: ppc64
> > > >
> > > > FAIL: LOCAL1 (0)
> > 
> > I've seen the above fail with LOCAL1 (2), which actually needs to be
> > flagged as a success. I guess the issue is with checking of rc -- down
> > in alternatives.exp:
> > 
> > - if {$rc == 1} { pass $test } else { fail "$test ($rc)" }
> > + if {$rc >= 1} { pass $test } else { fail "$test ($rc)" }
> > 
> > should fix the problem.
> 
> Yes, that seems fine. The LOCAL1 (0) failure case is as you observed
> because of the syscall wrappers issue (I am thinking about the patch you
> proposed in PR10007 and testing it locally - x86_64 only for now
> though).

Thanks Mark. I've attached an updated version just now.

Ananth