From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21467 invoked by alias); 13 May 2009 15:20:58 -0000 Received: (qmail 21453 invoked by uid 22791); 13 May 2009 15:20:55 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 May 2009 15:20:49 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n4DFKkNQ001701 for ; Wed, 13 May 2009 11:20:46 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4DFKjf8009994 for ; Wed, 13 May 2009 11:20:45 -0400 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4DFKiAi008843; Wed, 13 May 2009 11:20:44 -0400 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 13519) id E052018D460; Wed, 13 May 2009 18:20:43 +0300 (IDT) Date: Wed, 13 May 2009 15:20:00 -0000 From: Gleb Natapov To: Masami Hiramatsu Cc: Przemysssaw Paweeeczyk , Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm , Jim Keniston , "H. Peter Anvin" , Ananth N Mavinakayanahalli , Frederic Weisbecker , Andi Kleen , Vegard Nossum , Avi Kivity Subject: Re: [PATCH -tip v5 1/7] x86: instruction decorder API Message-ID: <20090513152043.GX18554@redhat.com> References: <20090509004829.5505.38720.stgit@localhost.localdomain> <20090509004841.5505.48140.stgit@localhost.localdomain> <20090513082310.GQ18554@redhat.com> <40e92d5b0905130235p2c60bd56y4f001247e11d6302@mail.gmail.com> <20090513094326.GA22281@redhat.com> <4A0ADACB.8030205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A0ADACB.8030205@redhat.com> Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00573.txt.bz2 On Wed, May 13, 2009 at 10:35:55AM -0400, Masami Hiramatsu wrote: > Gleb Natapov wrote: > > On Wed, May 13, 2009 at 11:35:16AM +0200, Przemysssaw Paweeeczyk wrote: > >> On Wed, May 13, 2009 at 10:23, Gleb Natapov wrote: > >>> On Fri, May 08, 2009 at 08:48:42PM -0400, Masami Hiramatsu wrote: > >>>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk > >>>> @@ -0,0 +1,314 @@ > >>>> +#!/bin/awk -f > >>> On some distributions (debian) it is /usr/bin/awk. > >> True, but on most of them (all?) there is also an appropriate link in /bin. > > Nope, not on debian testing. Although I assume if kernel compilation > > will start to fail it will appear :) > > > >> If shebang could have more that one argument, then '/usr/bin/env awk > >> -f' would be the best solution I think. > > Ah, I see. > Actually, it will be executed from Makefile with 'awk -f'. > > > --- a/arch/x86/lib/Makefile > > +++ b/arch/x86/lib/Makefile > > @@ -2,12 +2,21 @@ > > # Makefile for x86 specific library files. > > # > > > > +quiet_cmd_inat_tables = GEN $@ > > + cmd_inat_tables = awk -f $(srctree)/arch/x86/scripts/gen-insn-attr-x86.awk $(srctree)/arch/x86/lib/x86-opcode-map.txt > $@ > > + > > So, if awk is on the PATH, it will pass. Ah, that is good enough I thing. I tried to run scrip manually. > Maybe, I need to add 'HOSTAWK = awk' line in Makefile. > -- Gleb.