[Bug translator/10075] New: emit more error message details in probe registration logic

[Bug translator/10075] New: emit more error message details in probe registration logic

[fche at redhat dot com]

In the derived_probe_group registration logic, each registration
attempt only passes an rc and the probe_point string back for
reporting.  It would be nice to have an additional char[] available
to print more stuff into, so for example if a kprobe_register fails,
we don't just get

WARNING: probe
module("kvm").function("kvm_vcpu_init@arch/x86/kvm/../../../virt/kvm/kvm_main.c:6\
17").call
registration error (rc -22)

but also something else, which for kprobes could include data regarding the
calculation of the kprobe address.

-- 
           Summary: emit more error message details in probe registration
                    logic
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10075

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10075] emit more error message details in probe registration logic

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-07-10 09:35 -------
Created an attachment (id=4047)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4047&action=view)
patch to emit address related to probe

With the patch, registering bad probe will generate:
WARNING: probe kernel.statement(-1).absolute (address 0xffffffff) registration
error (rc -22)

The probe address is added to error message. Another possible item is to 
convert -22 to -EINVAL.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10075

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10075] emit more error message details in probe registration logic

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-07-13 07:52 -------
See commit	4a4edc21a14792a4cc240b601912734027945ae8

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10075

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10075] emit more error message details in probe registration logic

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2009-07-16 20:44 -------
committed


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10075

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.