From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19499 invoked by alias); 29 Jul 2009 04:24:40 -0000 Received: (qmail 19492 invoked by uid 22791); 29 Jul 2009 04:24:40 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,NO_DNS_FOR_FROM X-Spam-Check-By: sourceware.org Received: from e6.ny.us.ibm.com (HELO e6.ny.us.ibm.com) (32.97.182.146) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jul 2009 04:24:36 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6T4S5CU008479 for ; Wed, 29 Jul 2009 00:28:05 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6T4ORGP242658 for ; Wed, 29 Jul 2009 00:24:27 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6T4LjM1021150 for ; Wed, 29 Jul 2009 00:21:45 -0400 Received: from thinktux.in.ibm.com ([9.124.35.145]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n6T4Liju021026; Wed, 29 Jul 2009 00:21:45 -0400 Received: by thinktux.in.ibm.com (Postfix, from userid 500) id A3C558962A; Wed, 29 Jul 2009 09:54:23 +0530 (IST) Date: Wed, 29 Jul 2009 04:24:00 -0000 From: Ananth N Mavinakayanahalli To: Masami Hiramatsu Cc: Linus Torvalds, lkml, systemtap, Jim Keniston Subject: Re: [BUGFIX PATCH] kprobes: Use kernel_text_address() for checking probe address Message-ID: <20090729042423.GA5232@in.ibm.com> Reply-To: ananth@in.ibm.com References: <20090728234723.15708.54455.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090728234723.15708.54455.stgit@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00224.txt.bz2 On Tue, Jul 28, 2009 at 07:47:23PM -0400, Masami Hiramatsu wrote: > Use kernel_text_address() for checking probe address instead of > __kernel_text_address(), because __kernel_text_address() returns > !0 for init functions even after relaseing those functions. > That will hit a BUG() in text_poke(). > > Signed-off-by: Masami Hiramatsu > Cc: Ananth N Mavinakayanahalli > Cc: Jim Keniston Acked-by: Ananth N Mavinakayanahalli